jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-12 15:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use _attr_should_poll in econet (#77262)

Browse Source
This commit is contained in:
epenet 2022-08-26 10:21:13 +02:00 committed by GitHub
parent 2a8109304f
commit f9a46cc79f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
homeassistant/components/econet/__init__.py
View File

@ -111,6 +111,8 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
class EcoNetEntity(Entity): class EcoNetEntity(Entity):
"""Define a base EcoNet entity.""" """Define a base EcoNet entity."""
_attr_should_poll = False
def __init__(self, econet): def __init__(self, econet):
"""Initialize.""" """Initialize."""
self._econet = econet self._econet = econet
@ -155,11 +157,3 @@ class EcoNetEntity(Entity):
def temperature_unit(self): def temperature_unit(self):
"""Return the unit of measurement.""" """Return the unit of measurement."""
return TEMP_FAHRENHEIT return TEMP_FAHRENHEIT
@property
def should_poll(self) -> bool:
"""Return True if entity has to be polled for state.
False if entity pushes its state to HA.
"""
return False

14
homeassistant/components/econet/water_heater.py
View File

@ -62,7 +62,7 @@ class EcoNetWaterHeater(EcoNetEntity, WaterHeaterEntity):
"""Initialize.""" """Initialize."""
super().__init__(water_heater) super().__init__(water_heater)
self._running = water_heater.running self._running = water_heater.running
self._poll = True self._attr_should_poll = True # Override False default from EcoNetEntity
self.water_heater = water_heater self.water_heater = water_heater
self.econet_state_to_ha = {} self.econet_state_to_ha = {}
self.ha_state_to_econet = {} self.ha_state_to_econet = {}
@ -72,7 +72,7 @@ class EcoNetWaterHeater(EcoNetEntity, WaterHeaterEntity):
"""Update was pushed from the ecoent API.""" """Update was pushed from the ecoent API."""
if self._running != self.water_heater.running: if self._running != self.water_heater.running:
# Water heater running state has changed so check usage on next update # Water heater running state has changed so check usage on next update
self._poll = True self._attr_should_poll = True
self._running = self.water_heater.running self._running = self.water_heater.running
self.async_write_ha_state() self.async_write_ha_state()
@ -149,20 +149,12 @@ class EcoNetWaterHeater(EcoNetEntity, WaterHeaterEntity):
"""Return the maximum temperature.""" """Return the maximum temperature."""
return self.water_heater.set_point_limits[1] return self.water_heater.set_point_limits[1]
@property
def should_poll(self) -> bool:
"""Return True if entity has to be polled for state.
False if entity pushes its state to HA.
"""
return self._poll
async def async_update(self) -> None: async def async_update(self) -> None:
"""Get the latest energy usage.""" """Get the latest energy usage."""
await self.water_heater.get_energy_usage() await self.water_heater.get_energy_usage()
await self.water_heater.get_water_usage() await self.water_heater.get_water_usage()
self.async_write_ha_state() self.async_write_ha_state()
self._poll = False self._attr_should_poll = False
def turn_away_mode_on(self) -> None: def turn_away_mode_on(self) -> None:
"""Turn away mode on.""" """Turn away mode on."""