From faeb663dfe27d0e06c52441f6db660b6af3e4c1c Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Fri, 14 Oct 2022 12:21:58 +0200 Subject: [PATCH] Adjust distance unit check in geonetnz_quakes (#80236) * Adjust length unit check in geonetnz_quakes * Use system compare * Use is not == * Apply suggestion Co-authored-by: Erik Montnemery Co-authored-by: Erik Montnemery --- homeassistant/components/geonetnz_quakes/__init__.py | 4 ++-- .../components/geonetnz_quakes/geo_location.py | 12 ++++-------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/homeassistant/components/geonetnz_quakes/__init__.py b/homeassistant/components/geonetnz_quakes/__init__.py index e4d766fa979..bef0ee4c1fd 100644 --- a/homeassistant/components/geonetnz_quakes/__init__.py +++ b/homeassistant/components/geonetnz_quakes/__init__.py @@ -11,7 +11,6 @@ from homeassistant.const import ( CONF_LONGITUDE, CONF_RADIUS, CONF_SCAN_INTERVAL, - CONF_UNIT_SYSTEM_IMPERIAL, LENGTH_KILOMETERS, LENGTH_MILES, ) @@ -21,6 +20,7 @@ from homeassistant.helpers.dispatcher import async_dispatcher_send from homeassistant.helpers.event import async_track_time_interval from homeassistant.helpers.typing import ConfigType from homeassistant.util.unit_conversion import DistanceConverter +from homeassistant.util.unit_system import IMPERIAL_SYSTEM from .const import ( CONF_MINIMUM_MAGNITUDE, @@ -95,7 +95,7 @@ async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> b feeds = hass.data[DOMAIN].setdefault(FEED, {}) radius = config_entry.data[CONF_RADIUS] - if hass.config.units.name == CONF_UNIT_SYSTEM_IMPERIAL: + if hass.config.units is IMPERIAL_SYSTEM: radius = DistanceConverter.convert(radius, LENGTH_MILES, LENGTH_KILOMETERS) # Create feed entity manager for all platforms. manager = GeonetnzQuakesFeedEntityManager(hass, config_entry, radius) diff --git a/homeassistant/components/geonetnz_quakes/geo_location.py b/homeassistant/components/geonetnz_quakes/geo_location.py index c6c872ba828..bd382f1767d 100644 --- a/homeassistant/components/geonetnz_quakes/geo_location.py +++ b/homeassistant/components/geonetnz_quakes/geo_location.py @@ -9,17 +9,13 @@ from aio_geojson_geonetnz_quakes.feed_entry import GeonetnzQuakesFeedEntry from homeassistant.components.geo_location import GeolocationEvent from homeassistant.config_entries import ConfigEntry -from homeassistant.const import ( - ATTR_TIME, - CONF_UNIT_SYSTEM_IMPERIAL, - LENGTH_KILOMETERS, - LENGTH_MILES, -) +from homeassistant.const import ATTR_TIME, LENGTH_KILOMETERS, LENGTH_MILES from homeassistant.core import HomeAssistant, callback from homeassistant.helpers import entity_registry as er from homeassistant.helpers.dispatcher import async_dispatcher_connect from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.util.unit_conversion import DistanceConverter +from homeassistant.util.unit_system import IMPERIAL_SYSTEM from . import GeonetnzQuakesFeedEntityManager from .const import DOMAIN, FEED @@ -97,7 +93,7 @@ class GeonetnzQuakesEvent(GeolocationEvent): async def async_added_to_hass(self) -> None: """Call when entity is added to hass.""" - if self.hass.config.units.name == CONF_UNIT_SYSTEM_IMPERIAL: + if self.hass.config.units is IMPERIAL_SYSTEM: self._attr_unit_of_measurement = LENGTH_MILES self._remove_signal_delete = async_dispatcher_connect( self.hass, @@ -140,7 +136,7 @@ class GeonetnzQuakesEvent(GeolocationEvent): """Update the internal state from the provided feed entry.""" self._attr_name = feed_entry.title # Convert distance if not metric system. - if self.hass.config.units.name == CONF_UNIT_SYSTEM_IMPERIAL: + if self.hass.config.units is IMPERIAL_SYSTEM: self._attr_distance = DistanceConverter.convert( feed_entry.distance_to_home, LENGTH_KILOMETERS, LENGTH_MILES )