jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 06:07:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

MQTT Cover Fix Assumed State (#14672)

Browse Source
This commit is contained in:
Otto Winter 2018-05-29 15:03:45 +02:00 committed by Paulus Schoutsen
parent f2a2f2cca5
commit fcb60d472e
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/cover/mqtt.py
View File

@ -235,6 +235,11 @@ class MqttCover(MqttAvailability, CoverDevice):
"""No polling needed.""" """No polling needed."""
return False return False
@property
def assumed_state(self):
"""Return true if we do optimistic updates."""
return self._optimistic
@property @property
def name(self): def name(self):
"""Return the name of the cover.""" """Return the name of the cover."""

6
tests/components/cover/test_mqtt.py
View File

@ -2,8 +2,8 @@
import unittest import unittest
from homeassistant.setup import setup_component from homeassistant.setup import setup_component
from homeassistant.const import STATE_OPEN, STATE_CLOSED, STATE_UNKNOWN,\ from homeassistant.const import STATE_OPEN, STATE_CLOSED, STATE_UNKNOWN, \
STATE_UNAVAILABLE STATE_UNAVAILABLE, ATTR_ASSUMED_STATE
import homeassistant.components.cover as cover import homeassistant.components.cover as cover
from homeassistant.components.cover.mqtt import MqttCover from homeassistant.components.cover.mqtt import MqttCover
@ -40,6 +40,7 @@ class TestCoverMQTT(unittest.TestCase):
state = self.hass.states.get('cover.test') state = self.hass.states.get('cover.test')
self.assertEqual(STATE_UNKNOWN, state.state) self.assertEqual(STATE_UNKNOWN, state.state)
self.assertFalse(state.attributes.get(ATTR_ASSUMED_STATE))
fire_mqtt_message(self.hass, 'state-topic', '0') fire_mqtt_message(self.hass, 'state-topic', '0')
self.hass.block_till_done() self.hass.block_till_done()
@ -112,6 +113,7 @@ class TestCoverMQTT(unittest.TestCase):
state = self.hass.states.get('cover.test') state = self.hass.states.get('cover.test')
self.assertEqual(STATE_UNKNOWN, state.state) self.assertEqual(STATE_UNKNOWN, state.state)
self.assertTrue(state.attributes.get(ATTR_ASSUMED_STATE))
cover.open_cover(self.hass, 'cover.test') cover.open_cover(self.hass, 'cover.test')
self.hass.block_till_done() self.hass.block_till_done()