jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-08 05:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Decouple service registration in Renault (#143210)

Browse Source
This commit is contained in:
epenet 2025-04-19 12:36:54 +02:00 committed by GitHub
parent 3da77726d0
commit ff1ab1da37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 73 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
homeassistant/components/renault/services.py
View File

@ -2,7 +2,6 @@
from __future__ import annotations from __future__ import annotations
from collections.abc import Mapping
from datetime import datetime from datetime import datetime
import logging import logging
from typing import TYPE_CHECKING, Any from typing import TYPE_CHECKING, Any
@ -105,31 +104,30 @@ SERVICES = [
] ]
def setup_services(hass: HomeAssistant) -> None:
"""Register the Renault services."""
async def ac_cancel(service_call: ServiceCall) -> None: async def ac_cancel(service_call: ServiceCall) -> None:
"""Cancel A/C.""" """Cancel A/C."""
proxy = get_vehicle_proxy(service_call.data) proxy = get_vehicle_proxy(service_call)
LOGGER.debug("A/C cancel attempt") LOGGER.debug("A/C cancel attempt")
result = await proxy.set_ac_stop() result = await proxy.set_ac_stop()
LOGGER.debug("A/C cancel result: %s", result) LOGGER.debug("A/C cancel result: %s", result)
async def ac_start(service_call: ServiceCall) -> None: async def ac_start(service_call: ServiceCall) -> None:
"""Start A/C.""" """Start A/C."""
temperature: float = service_call.data[ATTR_TEMPERATURE] temperature: float = service_call.data[ATTR_TEMPERATURE]
when: datetime | None = service_call.data.get(ATTR_WHEN) when: datetime | None = service_call.data.get(ATTR_WHEN)
proxy = get_vehicle_proxy(service_call.data) proxy = get_vehicle_proxy(service_call)
LOGGER.debug("A/C start attempt: %s / %s", temperature, when) LOGGER.debug("A/C start attempt: %s / %s", temperature, when)
result = await proxy.set_ac_start(temperature, when) result = await proxy.set_ac_start(temperature, when)
LOGGER.debug("A/C start result: %s", result.raw_data) LOGGER.debug("A/C start result: %s", result.raw_data)
async def charge_set_schedules(service_call: ServiceCall) -> None: async def charge_set_schedules(service_call: ServiceCall) -> None:
"""Set charge schedules.""" """Set charge schedules."""
schedules: list[dict[str, Any]] = service_call.data[ATTR_SCHEDULES] schedules: list[dict[str, Any]] = service_call.data[ATTR_SCHEDULES]
proxy = get_vehicle_proxy(service_call.data) proxy = get_vehicle_proxy(service_call)
charge_schedules = await proxy.get_charging_settings() charge_schedules = await proxy.get_charging_settings()
for schedule in schedules: for schedule in schedules:
charge_schedules.update(schedule) charge_schedules.update(schedule)
@ -144,10 +142,11 @@ def setup_services(hass: HomeAssistant) -> None:
"It may take some time before these changes are reflected in your vehicle" "It may take some time before these changes are reflected in your vehicle"
) )
async def ac_set_schedules(service_call: ServiceCall) -> None: async def ac_set_schedules(service_call: ServiceCall) -> None:
"""Set A/C schedules.""" """Set A/C schedules."""
schedules: list[dict[str, Any]] = service_call.data[ATTR_SCHEDULES] schedules: list[dict[str, Any]] = service_call.data[ATTR_SCHEDULES]
proxy = get_vehicle_proxy(service_call.data) proxy = get_vehicle_proxy(service_call)
hvac_schedules = await proxy.get_hvac_settings() hvac_schedules = await proxy.get_hvac_settings()
for schedule in schedules: for schedule in schedules:
@ -163,10 +162,11 @@ def setup_services(hass: HomeAssistant) -> None:
"It may take some time before these changes are reflected in your vehicle" "It may take some time before these changes are reflected in your vehicle"
) )
def get_vehicle_proxy(service_call_data: Mapping) -> RenaultVehicleProxy:
def get_vehicle_proxy(service_call: ServiceCall) -> RenaultVehicleProxy:
"""Get vehicle from service_call data.""" """Get vehicle from service_call data."""
device_registry = dr.async_get(hass) device_registry = dr.async_get(service_call.hass)
device_id = service_call_data[ATTR_VEHICLE] device_id = service_call.data[ATTR_VEHICLE]
device_entry = device_registry.async_get(device_id) device_entry = device_registry.async_get(device_id)
if device_entry is None: if device_entry is None:
raise ServiceValidationError( raise ServiceValidationError(
@ -177,7 +177,7 @@ def setup_services(hass: HomeAssistant) -> None:
loaded_entries: list[RenaultConfigEntry] = [ loaded_entries: list[RenaultConfigEntry] = [
entry entry
for entry in hass.config_entries.async_loaded_entries(DOMAIN) for entry in service_call.hass.config_entries.async_loaded_entries(DOMAIN)
if entry.entry_id in device_entry.config_entries if entry.entry_id in device_entry.config_entries
] ]
for entry in loaded_entries: for entry in loaded_entries:
@ -190,6 +190,10 @@ def setup_services(hass: HomeAssistant) -> None:
translation_placeholders={"device_id": device_entry.name or device_id}, translation_placeholders={"device_id": device_entry.name or device_id},
) )
def setup_services(hass: HomeAssistant) -> None:
"""Register the Renault services."""
hass.services.async_register( hass.services.async_register(
DOMAIN, DOMAIN,
SERVICE_AC_CANCEL, SERVICE_AC_CANCEL,