jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 21:57:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix circular import of scapy in dhcp (#56040)

Browse Source 
* Fix circular import of scapy in dhcp

* Tweak import, add comment

* Tweak import, add comment

* pylint
This commit is contained in:
J. Nick Koston 2021-09-10 10:04:54 +02:00 committed by GitHub
parent 970a7f9662
commit ff1b39cda6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
homeassistant/components/dhcp/__init__.py
View File

@ -279,6 +279,17 @@ class DHCPWatcher(WatcherBase):
"""Start watching for dhcp packets.""" """Start watching for dhcp packets."""
# Local import because importing from scapy has side effects such as opening # Local import because importing from scapy has side effects such as opening
# sockets # sockets
from scapy import ( # pylint: disable=import-outside-toplevel,unused-import # noqa: F401
arch,
)
#
# Importing scapy.sendrecv will cause a scapy resync which will
# import scapy.arch.read_routes which will import scapy.sendrecv
#
# We avoid this circular import by importing arch above to ensure
# the module is loaded and avoid the problem
#
from scapy.sendrecv import ( # pylint: disable=import-outside-toplevel from scapy.sendrecv import ( # pylint: disable=import-outside-toplevel
AsyncSniffer, AsyncSniffer,
) )