From ff535053a9ae70a00cd2135b292f9395ff56ef8a Mon Sep 17 00:00:00 2001 From: Aaron Bach Date: Thu, 20 Jan 2022 19:37:05 -0700 Subject: [PATCH] Use return_value in Flu Near You config flow tests (#64596) --- tests/components/flunearyou/conftest.py | 2 +- tests/components/flunearyou/test_config_flow.py | 17 ++++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/tests/components/flunearyou/conftest.py b/tests/components/flunearyou/conftest.py index a2c0fbac173..ff539b08a42 100644 --- a/tests/components/flunearyou/conftest.py +++ b/tests/components/flunearyou/conftest.py @@ -38,7 +38,7 @@ def data_cdc_fixture(): async def setup_flunearyou_fixture(hass, config, data_cdc): """Define a fixture to set up Flu Near You.""" with patch( - "pyflunearyou.cdc.CdcReport.status_by_coordinates", side_effect=data_cdc + "pyflunearyou.cdc.CdcReport.status_by_coordinates", return_value=data_cdc ), patch("pyflunearyou.user.UserReport.status_by_coordinates"), patch( "homeassistant.components.flunearyou.PLATFORMS", [] ): diff --git a/tests/components/flunearyou/test_config_flow.py b/tests/components/flunearyou/test_config_flow.py index 033768601bf..8c22d5fc915 100644 --- a/tests/components/flunearyou/test_config_flow.py +++ b/tests/components/flunearyou/test_config_flow.py @@ -1,6 +1,7 @@ """Define tests for the flunearyou config flow.""" +from unittest.mock import patch + from pyflunearyou.errors import FluNearYouError -import pytest from homeassistant import data_entry_flow from homeassistant.components.flunearyou import DOMAIN @@ -17,13 +18,15 @@ async def test_duplicate_error(hass, config, config_entry, setup_flunearyou): assert result["reason"] == "already_configured" -@pytest.mark.parametrize("data_cdc", [FluNearYouError]) -async def test_errors(hass, config, data_cdc, setup_flunearyou): +async def test_errors(hass, config): """Test that exceptions show the appropriate error.""" - result = await hass.config_entries.flow.async_init( - DOMAIN, context={"source": SOURCE_USER}, data=config - ) - assert result["errors"] == {"base": "unknown"} + with patch( + "pyflunearyou.cdc.CdcReport.status_by_coordinates", side_effect=FluNearYouError + ): + result = await hass.config_entries.flow.async_init( + DOMAIN, context={"source": SOURCE_USER}, data=config + ) + assert result["errors"] == {"base": "unknown"} async def test_show_form(hass):