core/tests/components/ring/test_number.py
Daniel Krebs c8e2408f82
Allow setting volume on Ring devices (#125773)
* Turn Ring Doorbell and Chime volumes into number entities.

* turn RingOther volumes into numbers as well

* fix linter issues

* move other volume strings into `number` section

* add back old volume sensors but deprecate them

* add tests for `ring.number`

* add back strings for sensors that have just become deprecated

* remove deprecated volume sensors from test

* Revert "remove deprecated volume sensors from test"

This reverts commit fc95af66e7136202dca9560325d88b811ec22c45.

* create entities for deprecated sensors so that tests still run

* remove print

* add entities immediately

* move `RingNumberEntityDescription` above `RingNumber` and remove unused import

* remove irrelevant comment about history

* fix not using `setter_fn`

* add missing icons for other volume entities

* rename `entity` -> `entity_id` in number tests

* fix typing in number test

* use constants for `hass.services.async_call()`

* use `@refresh_after` decorator instead of delaying updates manually

* move descriptors above entity class

* Use snapshot to test states.

* add missing snapshot file for number platform

* Update homeassistant/components/ring/number.py

Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>

---------

Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>
2024-09-17 15:41:51 +02:00

96 lines
2.7 KiB
Python

"""The tests for the Ring number platform."""
from unittest.mock import Mock
import pytest
from syrupy.assertion import SnapshotAssertion
from homeassistant.components.number import (
ATTR_VALUE,
DOMAIN as NUMBER_DOMAIN,
SERVICE_SET_VALUE,
)
from homeassistant.const import ATTR_ENTITY_ID, Platform
from homeassistant.core import HomeAssistant
from homeassistant.helpers import entity_registry as er
from .common import MockConfigEntry, setup_platform
from tests.common import snapshot_platform
@pytest.mark.parametrize(
("entity_id", "unique_id"),
[
("number.downstairs_volume", "123456-volume"),
("number.front_door_volume", "987654-volume"),
("number.ingress_doorbell_volume", "185036587-doorbell_volume"),
("number.ingress_mic_volume", "185036587-mic_volume"),
("number.ingress_voice_volume", "185036587-voice_volume"),
],
)
async def test_entity_registry(
hass: HomeAssistant,
entity_registry: er.EntityRegistry,
mock_ring_client: Mock,
entity_id: str,
unique_id: str,
) -> None:
"""Tests that the devices are registered in the entity registry."""
await setup_platform(hass, Platform.NUMBER)
entry = entity_registry.async_get(entity_id)
assert entry is not None and entry.unique_id == unique_id
async def test_states(
hass: HomeAssistant,
mock_ring_client: Mock,
mock_config_entry: MockConfigEntry,
entity_registry: er.EntityRegistry,
snapshot: SnapshotAssertion,
) -> None:
"""Test states."""
mock_config_entry.add_to_hass(hass)
await setup_platform(hass, Platform.NUMBER)
await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)
@pytest.mark.parametrize(
("entity_id", "new_value"),
[
("number.downstairs_volume", "4.0"),
("number.front_door_volume", "3.0"),
("number.ingress_doorbell_volume", "7.0"),
("number.ingress_mic_volume", "2.0"),
("number.ingress_voice_volume", "5.0"),
],
)
async def test_volume_can_be_changed(
hass: HomeAssistant,
mock_ring_client: Mock,
entity_id: str,
new_value: str,
) -> None:
"""Tests the volume can be changed correctly."""
await setup_platform(hass, Platform.NUMBER)
state = hass.states.get(entity_id)
assert state is not None
old_value = state.state
# otherwise this test would be pointless
assert old_value != new_value
await hass.services.async_call(
NUMBER_DOMAIN,
SERVICE_SET_VALUE,
{ATTR_ENTITY_ID: entity_id, ATTR_VALUE: new_value},
blocking=True,
)
await hass.async_block_till_done()
state = hass.states.get(entity_id)
assert state is not None and state.state == new_value