From 7d2aebb3e525be031ba6f85eacfc4b48e14be9d1 Mon Sep 17 00:00:00 2001 From: G Johansson Date: Wed, 23 Aug 2023 07:15:46 +0200 Subject: [PATCH] Add ADR to the PR review process (#1882) * Update review-process.md * Update review-process.md * mod --- docs/review-process.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/review-process.md b/docs/review-process.md index 4cf05176..2098c74d 100644 --- a/docs/review-process.md +++ b/docs/review-process.md @@ -31,6 +31,16 @@ or even just a "I tested this using ... and it works" is very much appreciated. Besides, looking at code of others is a great way to learn more about Home Assistant. +## Before creating your PR + +**Comply with Architectural Decisions.** + +All architectural decisions around the Home Assistant project are recorded in +the [ADR folder](https://github.com/home-assistant/architecture/tree/master/adr). +Ensure these rules and guidelines are followed before creating your PR +to avoid later adjustments based on your PR not following these rules. +If needed a new [discussion](https://github.com/home-assistant/architecture/discussions) can take place to make the necessary decision prior to submitting a PR for review. + ## Creating the perfect PR There is no such thing as a perfect PR, but there are some things you can