jeans/developers.home-assistant
jeans/developers.home-assistant
1
0
Fork 0
mirror of https://github.com/home-assistant/developers.home-assistant.git synced 2025-07-16 22:06:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Document our preference for smaller component PRs (#145)

Browse Source
This commit is contained in:
Adam Mills 2018-11-09 04:33:14 -05:00 committed by Paulus Schoutsen
parent 3fde2e4f40
commit 90c56955a3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/creating_component_code_review.md
View File

@ -46,3 +46,6 @@ from phue import Bridge
bridge = Bridge(...)
status = bridge.status()
```
### 5. Limit platforms included in initial pull request
Large pull requests mean there is a larger chance of finding problems that need to be addressed, and more code that needs to be reviewed between every requested change. If your new component will have multiple platforms, try and limit your initial pull request to a single platform. Once the initial component is merged, you can submit additional PRs for the remaining platforms. This allows reviewers to sign off on smaller chunks of code one at a time, and lets us get your new feature in sooner. Pull requests containing large code dumps will not be a priority for review.