From cad34a639302f0fb436a9993fe5b2a2475e4282e Mon Sep 17 00:00:00 2001 From: Allen Porter Date: Mon, 18 Oct 2021 19:01:22 -0700 Subject: [PATCH 1/2] Apply suggestions from code review Co-authored-by: Martin Hjelmare --- docs/core/entity/camera.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/core/entity/camera.md b/docs/core/entity/camera.md index e07c1723..d0234a0d 100644 --- a/docs/core/entity/camera.md +++ b/docs/core/entity/camera.md @@ -67,7 +67,7 @@ class MyCamera(Camera): The stream source should return an RTSP URL that is usable by ffmpeg. Requires `SUPPORT_STREAM`. -A camera entity with a stream source by default use `STREAM_TYPE_HLS` to tell the frontend to use an HLS feed with the `stream` component. This stream source is also be used with `stream` for recording. +A camera entity with a stream source by default uses `STREAM_TYPE_HLS` to tell the frontend to use an HLS feed with the `stream` component. This stream source will also be used with `stream` for recording. ```python class MyCamera(Camera): @@ -95,7 +95,7 @@ class MyCamera(Camera): ### WebRTC Streams -WebRTC enabled cameras can be used with the home assistant frontend. Requires `SUPPORT_STREAM`. A camera entity may set `frontend_stream_type` to `STREAM_TYPE_WEB_RTC` and implement the signal path to pass the frontends SDP offer to the +WebRTC enabled cameras can be used with the home assistant frontend. Requires `SUPPORT_STREAM`. A camera entity may set `frontend_stream_type` to `STREAM_TYPE_WEB_RTC` and implement the signal path to pass the frontend's SDP offer to the device, and return back the answer. The stream is initiated from the frontend which talks directly to the device. WebRTC streams do not use the `stream` component and do not support recording. From ff1849f983c85a4a0ce1b92233a63faa8f70c9f2 Mon Sep 17 00:00:00 2001 From: Allen Porter Date: Tue, 19 Oct 2021 20:36:20 -0700 Subject: [PATCH 2/2] Update docs/core/entity/camera.md Co-authored-by: uvjustin <46082645+uvjustin@users.noreply.github.com> --- docs/core/entity/camera.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/core/entity/camera.md b/docs/core/entity/camera.md index d0234a0d..28770810 100644 --- a/docs/core/entity/camera.md +++ b/docs/core/entity/camera.md @@ -95,7 +95,7 @@ class MyCamera(Camera): ### WebRTC Streams -WebRTC enabled cameras can be used with the home assistant frontend. Requires `SUPPORT_STREAM`. A camera entity may set `frontend_stream_type` to `STREAM_TYPE_WEB_RTC` and implement the signal path to pass the frontend's SDP offer to the +WebRTC enabled cameras can be used by facilitating a direct connection with the home assistant frontend. This usage requires `SUPPORT_STREAM` with `frontend_stream_type` set to `STREAM_TYPE_WEB_RTC`. The integration should implement `async_handle_web_rtc_offer` which passes the frontend's SDP offer to the device and returns back the answer. device, and return back the answer. The stream is initiated from the frontend which talks directly to the device. WebRTC streams do not use the `stream` component and do not support recording.