From cae565b4a4b9973c1eeaed40f2f3c26db6f05542 Mon Sep 17 00:00:00 2001 From: Shay Levy Date: Thu, 21 Apr 2022 15:53:27 +0300 Subject: [PATCH] Update development checklist - issue trackers for external packages (#1299) * Update development checklist - issue trackers for external Python libraries * Update docs/development_checklist.md Co-authored-by: Martin Hjelmare Co-authored-by: Martin Hjelmare --- docs/development_checklist.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/development_checklist.md b/docs/development_checklist.md index 5dcf0e53..66dbf3bb 100644 --- a/docs/development_checklist.md +++ b/docs/development_checklist.md @@ -6,6 +6,8 @@ sidebar_label: Introduction Before you commit any changes, check your work against these requirements: - All communication to external devices or services must be wrapped in an external Python library hosted on [pypi](https://pypi.python.org/pypi). + - Issue trackers must be enabled for external Python libraries that has communication with external devices or services. + - If the library is mainly used for Home Assistant and you are a code owner of the integration it is encouraged to use an issue template picker with links to [Home Assistant Core Issues](https://github.com/home-assistant/core/issues). For example: [zwave-js-server-python - New Issue](https://github.com/home-assistant-libs/zwave-js-server-python/issues/new/choose) - New dependencies are added to `requirements_all.txt` (if applicable), using `python3 -m script.gen_requirements_all` - New codeowners are added to `CODEOWNERS` (if applicable), using `python3 -m script.hassfest` - The `.coveragerc` file is updated to exclude your platform if there are no tests available or your new code uses a third-party library for communication with the device, service, or sensor. `config_flow.py` can't be excluded as it must be fully tested (100% coverage).