From f5f5538e82b6cedcf907c158eb183924a975fb16 Mon Sep 17 00:00:00 2001 From: Adam Mills Date: Wed, 7 Nov 2018 04:10:35 -0500 Subject: [PATCH] Clarify requirement for external libraries (#143) This change clarifies that hass should not be responsible for third party communication details, and that these belong in an external library. --- docs/development_checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/development_checklist.md b/docs/development_checklist.md index 67c22b61..1584af0d 100644 --- a/docs/development_checklist.md +++ b/docs/development_checklist.md @@ -5,9 +5,9 @@ title: "Development Checklist" Before you commit any changes, check your work against these requirements: +- All communication to external devices or services must be wrapped in an external Python library hosted on [pypi](https://pypi.python.org/pypi). - All dependencies from [pypi](https://pypi.python.org/pypi) are included via the `REQUIREMENTS` variable in your platform or component and only imported inside functions that use them - New dependencies are added to `requirements_all.txt` (if applicable), using `script/gen_requirements_all.py` - The `.coveragerc` file is updated to exclude your platform if there are no tests available or your new code uses a third-party library for communication with the device, service, or sensor - Documentation is developed for [home-assistant.io](/) * It's OK to start with adding a docstring with configuration details (for example, sample entry for `configuration.yaml` file) to the file header. Visit the [website documentation](https://www.home-assistant.io/developers/documentation/) for more information about contributing to [home-assistant.io](https://github.com/home-assistant/home-assistant.github.io). -