From f9a778e93d782eacdd94c28d9202e4e31000f90f Mon Sep 17 00:00:00 2001
From: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com>
Date: Sat, 30 Mar 2019 23:06:37 -0500
Subject: [PATCH] Update component check list to describe MVP (#207)

* Update component code review

* Fix broken link

* Feedback updates

* More review feedback

* Remove large size

* Clarify test language
---
 docs/creating_component_code_review.md | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/docs/creating_component_code_review.md b/docs/creating_component_code_review.md
index a89ab732..dcaa3ce9 100644
--- a/docs/creating_component_code_review.md
+++ b/docs/creating_component_code_review.md
@@ -47,8 +47,16 @@ bridge = Bridge(...)
 status = bridge.status()
 ```
 
-### 5. Limit platforms included in initial pull request
-Large pull requests mean there is a larger chance of finding problems that need to be addressed, and more code that needs to be reviewed between every requested change. If your new component will have multiple platforms, try and limit your initial pull request to a single platform. Once the initial component is merged, you can submit additional PRs for the remaining platforms. This allows reviewers to sign off on smaller chunks of code one at a time, and lets us get your new feature in sooner. Pull requests containing large code dumps will not be a priority for review.
+### 5. Make your pull request as small as possible
+Keep a new integration to the minimum functionality needed for someone to get value out of the integration. This allows reviewers to sign off on smaller chunks of code one at a time, and lets us get your new integration/features in sooner. **Pull requests containing large code dumps will not be a priority for review and may be closed.**
+- Limit to a single platform 
+- Do not add features not needed to directly support the single platform (such as custom services)
+- Do not mix clean-ups and new features in a single pull request.
+- Do not solve several issues in a single pull request.
+- Do not submit pull requests that depend on other work which is still unmerged.
 
 ### 6. Event names
 Prefix component event names with the component name itself. For example, use `netatmo_person` instead of `person` for the `netatmo` component.
+
+### 7. Tests
+Strongly consider adding tests for your component to minimize future regressions.