From 47f954383108c51928f8f0b1b78de39d3b6789d8 Mon Sep 17 00:00:00 2001
From: Paulus Schoutsen <balloob@gmail.com>
Date: Wed, 11 Jan 2023 22:51:59 -0500
Subject: [PATCH] Code split smarter to get port picking done first (#310)

---
 src/connect.ts        |  2 +-
 src/install-button.ts | 10 ++--------
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/connect.ts b/src/connect.ts
index 5a9a394..a196cdc 100644
--- a/src/connect.ts
+++ b/src/connect.ts
@@ -1,7 +1,7 @@
 import type { InstallButton } from "./install-button.js";
-import "./install-dialog.js";
 
 export const connect = async (button: InstallButton) => {
+  import("./install-dialog.js");
   let port: SerialPort | undefined;
   try {
     port = await navigator.serial.requestPort();
diff --git a/src/install-button.ts b/src/install-button.ts
index 673c08a..873aeda 100644
--- a/src/install-button.ts
+++ b/src/install-button.ts
@@ -1,5 +1,6 @@
 import type { FlashState } from "./const";
 import type { EwtInstallDialog } from "./install-dialog";
+import { connect } from "./connect";
 
 export class InstallButton extends HTMLElement {
   public static isSupported = "serial" in navigator;
@@ -74,10 +75,6 @@ export class InstallButton extends HTMLElement {
 
   public overrides: EwtInstallDialog["overrides"];
 
-  public static preload() {
-    import("./connect");
-  }
-
   public connectedCallback() {
     if (this.renderRoot) {
       return;
@@ -95,14 +92,11 @@ export class InstallButton extends HTMLElement {
 
     this.toggleAttribute("install-supported", true);
 
-    this.addEventListener("mouseover", InstallButton.preload);
-
     const slot = document.createElement("slot");
 
     slot.addEventListener("click", async (ev) => {
       ev.preventDefault();
-      const mod = await import("./connect");
-      mod.connect(this);
+      connect(this);
     });
 
     slot.name = "activate";