[sht4x] Reduce warn spam, added communication check in setup (#8250)

Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
This commit is contained in:
Djordje Mandic 2025-04-23 10:45:29 +02:00 committed by GitHub
parent 991f3d3a10
commit 33d79e03d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 44 additions and 23 deletions

View File

@ -12,14 +12,22 @@ void SHT4XComponent::start_heater_() {
uint8_t cmd[] = {MEASURECOMMANDS[this->heater_command_]}; uint8_t cmd[] = {MEASURECOMMANDS[this->heater_command_]};
ESP_LOGD(TAG, "Heater turning on"); ESP_LOGD(TAG, "Heater turning on");
this->write(cmd, 1); if (this->write(cmd, 1) != i2c::ERROR_OK) {
this->status_set_error("Failed to turn on heater");
}
} }
void SHT4XComponent::setup() { void SHT4XComponent::setup() {
ESP_LOGCONFIG(TAG, "Setting up sht4x..."); ESP_LOGCONFIG(TAG, "Setting up sht4x...");
if (this->duty_cycle_ > 0.0) { auto err = this->write(nullptr, 0);
uint32_t heater_interval = (uint32_t) (this->heater_time_ / this->duty_cycle_); if (err != i2c::ERROR_OK) {
this->mark_failed();
return;
}
if (std::isfinite(this->duty_cycle_) && this->duty_cycle_ > 0.0f) {
uint32_t heater_interval = static_cast<uint32_t>(static_cast<uint16_t>(this->heater_time_) / this->duty_cycle_);
ESP_LOGD(TAG, "Heater interval: %" PRIu32, heater_interval); ESP_LOGD(TAG, "Heater interval: %" PRIu32, heater_interval);
if (this->heater_power_ == SHT4X_HEATERPOWER_HIGH) { if (this->heater_power_ == SHT4X_HEATERPOWER_HIGH) {
@ -47,37 +55,50 @@ void SHT4XComponent::setup() {
} }
} }
void SHT4XComponent::dump_config() { LOG_I2C_DEVICE(this); } void SHT4XComponent::dump_config() {
ESP_LOGCONFIG(TAG, "SHT4x:");
LOG_I2C_DEVICE(this);
if (this->is_failed()) {
ESP_LOGE(TAG, "Communication with SHT4x failed!");
}
}
void SHT4XComponent::update() { void SHT4XComponent::update() {
// Send command // Send command
this->write_command(MEASURECOMMANDS[this->precision_]); if (!this->write_command(MEASURECOMMANDS[this->precision_])) {
// Warning will be printed only if warning status is not set yet
this->status_set_warning("Failed to send measurement command");
return;
}
this->set_timeout(10, [this]() { this->set_timeout(10, [this]() {
uint16_t buffer[2]; uint16_t buffer[2];
// Read measurement // Read measurement
bool read_status = this->read_data(buffer, 2); if (!this->read_data(buffer, 2)) {
// Using ESP_LOGW to force the warning to be printed
ESP_LOGW(TAG, "Sensor read failed");
this->status_set_warning();
return;
}
if (read_status) { this->status_clear_warning();
// Evaluate and publish measurements
if (this->temp_sensor_ != nullptr) {
// Temp is contained in the first result word
float sensor_value_temp = buffer[0];
float temp = -45 + 175 * sensor_value_temp / 65535;
this->temp_sensor_->publish_state(temp); // Evaluate and publish measurements
} if (this->temp_sensor_ != nullptr) {
// Temp is contained in the first result word
float sensor_value_temp = buffer[0];
float temp = -45 + 175 * sensor_value_temp / 65535;
if (this->humidity_sensor_ != nullptr) { this->temp_sensor_->publish_state(temp);
// Relative humidity is in the second result word }
float sensor_value_rh = buffer[1];
float rh = -6 + 125 * sensor_value_rh / 65535;
this->humidity_sensor_->publish_state(rh); if (this->humidity_sensor_ != nullptr) {
} // Relative humidity is in the second result word
} else { float sensor_value_rh = buffer[1];
ESP_LOGD(TAG, "Sensor read failed"); float rh = -6 + 125 * sensor_value_rh / 65535;
this->humidity_sensor_->publish_state(rh);
} }
}); });
} }

View File

@ -13,7 +13,7 @@ enum SHT4XPRECISION { SHT4X_PRECISION_HIGH = 0, SHT4X_PRECISION_MED, SHT4X_PRECI
enum SHT4XHEATERPOWER { SHT4X_HEATERPOWER_HIGH, SHT4X_HEATERPOWER_MED, SHT4X_HEATERPOWER_LOW }; enum SHT4XHEATERPOWER { SHT4X_HEATERPOWER_HIGH, SHT4X_HEATERPOWER_MED, SHT4X_HEATERPOWER_LOW };
enum SHT4XHEATERTIME { SHT4X_HEATERTIME_LONG = 1100, SHT4X_HEATERTIME_SHORT = 110 }; enum SHT4XHEATERTIME : uint16_t { SHT4X_HEATERTIME_LONG = 1100, SHT4X_HEATERTIME_SHORT = 110 };
class SHT4XComponent : public PollingComponent, public sensirion_common::SensirionI2CDevice { class SHT4XComponent : public PollingComponent, public sensirion_common::SensirionI2CDevice {
public: public: