jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-08-10 12:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

address bot comments

Browse Source
This commit is contained in:
J. Nick Koston
2025-06-27 13:16:06 -05:00
parent 949689c318
commit 3b6bd55d1e
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
esphome/core/event_pool.h
View File

@@ -1,6 +1,6 @@
#pragma once #pragma once
#ifdef USE_ESP32 #if defined(USE_ESP32) || defined(USE_LIBRETINY)
#include <atomic> #include <atomic>
#include <cstddef> #include <cstddef>
@@ -17,6 +17,10 @@ template<class T, uint8_t SIZE> class EventPool {
~EventPool() { ~EventPool() {
// Clean up any remaining events in the free list // Clean up any remaining events in the free list
// IMPORTANT: This destructor assumes no concurrent access. The EventPool must not
// be destroyed while any thread might still call allocate() or release().
// In practice, this is typically ensured by destroying the pool only during
// component shutdown when all producer/consumer threads have been stopped.
T *event; T *event;
RAMAllocator<T> allocator(RAMAllocator<T>::ALLOC_INTERNAL); RAMAllocator<T> allocator(RAMAllocator<T>::ALLOC_INTERNAL);
while ((event = this->free_list_.pop()) != nullptr) { while ((event = this->free_list_.pop()) != nullptr) {
@@ -72,4 +76,4 @@ template<class T, uint8_t SIZE> class EventPool {
} // namespace esphome } // namespace esphome
#endif #endif // defined(USE_ESP32) || defined(USE_LIBRETINY)

15
esphome/core/lock_free_queue.h
View File

@@ -1,11 +1,17 @@
#pragma once #pragma once
#ifdef USE_ESP32 #if defined(USE_ESP32) || defined(USE_LIBRETINY)
#include <atomic> #include <atomic>
#include <cstddef> #include <cstddef>
#if defined(USE_ESP32)
#include <freertos/FreeRTOS.h> #include <freertos/FreeRTOS.h>
#include <freertos/task.h> #include <freertos/task.h>
#elif defined(USE_LIBRETINY)
#include <FreeRTOS.h>
#include <task.h>
#endif
/* /*
* Lock-free queue for single-producer single-consumer scenarios. * Lock-free queue for single-producer single-consumer scenarios.
@@ -13,6 +19,8 @@
* blocking each other. * blocking each other.
* *
* This is a Single-Producer Single-Consumer (SPSC) lock-free ring buffer. * This is a Single-Producer Single-Consumer (SPSC) lock-free ring buffer.
* Available on platforms with FreeRTOS support (ESP32, LibreTiny).
*
* Common use cases: * Common use cases:
* - BLE events: BLE task produces, main loop consumes * - BLE events: BLE task produces, main loop consumes
* - MQTT messages: main task produces, MQTT thread consumes * - MQTT messages: main task produces, MQTT thread consumes
@@ -56,6 +64,9 @@ template<class T, uint8_t SIZE> class LockFreeQueue {
uint8_t head_after = head_.load(std::memory_order_acquire); uint8_t head_after = head_.load(std::memory_order_acquire);
if (head_after == current_tail) { if (head_after == current_tail) {
// Consumer just caught up to where tail was - might go to sleep, must notify // Consumer just caught up to where tail was - might go to sleep, must notify
// Note: There's a benign race here - between reading head_after and calling
// xTaskNotifyGive(), the consumer could advance further. This would result
// in an unnecessary wake-up, but is harmless and extremely rare in practice.
xTaskNotifyGive(task_to_notify_); xTaskNotifyGive(task_to_notify_);
} }
// Otherwise: consumer is still behind, no need to notify // Otherwise: consumer is still behind, no need to notify
@@ -113,4 +124,4 @@ template<class T, uint8_t SIZE> class LockFreeQueue {
} // namespace esphome } // namespace esphome
#endif #endif // defined(USE_ESP32) || defined(USE_LIBRETINY)