jeans/esphome
jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-08-07 10:57:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix esp8266 error handling

Browse Source
This commit is contained in:
J. Nick Koston 2025-07-01 11:29:38 -05:00
parent cd1390916c
commit 825d0bed88
No known key found for this signature in database
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
esphome/components/ota_base/ota_backend_arduino_esp8266.cpp
View File

@ -63,13 +63,17 @@ OTAResponseTypes ArduinoESP8266OTABackend::write(uint8_t *data, size_t len) {
OTAResponseTypes ArduinoESP8266OTABackend::end() { OTAResponseTypes ArduinoESP8266OTABackend::end() {
// Use strict validation (false) when MD5 is set, lenient validation (true) when no MD5 // Use strict validation (false) when MD5 is set, lenient validation (true) when no MD5
// This matches the behavior of the old web_server OTA implementation // This matches the behavior of the old web_server OTA implementation
if (Update.end(!this->md5_set_)) { bool success = Update.end(!this->md5_set_);
// On ESP8266, Update.end() might return false even with error code 0
// Check the actual error code to determine success
uint8_t error = Update.getError();
if (success || error == UPDATE_ERROR_OK) {
return OTA_RESPONSE_OK; return OTA_RESPONSE_OK;
} }
uint8_t error = Update.getError();
ESP_LOGE(TAG, "End error: %d", error); ESP_LOGE(TAG, "End error: %d", error);
return OTA_RESPONSE_ERROR_UPDATE_END; return OTA_RESPONSE_ERROR_UPDATE_END;
} }