jeans/esphome
jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-07-29 06:36:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid Reallocation When Sending Logging Messages (#8714)

Browse Source
This commit is contained in:
J. Nick Koston 2025-05-07 23:19:53 -05:00 committed by GitHub
parent ad2b74d9b4
commit 882273cb56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
esphome/components/api/api_connection.cpp
View File

@ -1794,12 +1794,26 @@ bool APIConnection::try_send_log_message(int level, const char *tag, const char
if (this->log_subscription_ < level) if (this->log_subscription_ < level)
return false; return false;
// Send raw so that we don't copy too much // Pre-calculate message size to avoid reallocations
const size_t line_length = strlen(line);
uint32_t msg_size = 0;
// Add size for level field (field ID 1, varint type)
// 1 byte for field tag + size of the level varint
msg_size += 1 + api::ProtoSize::varint(static_cast<uint32_t>(level));
// Add size for string field (field ID 3, string type)
// 1 byte for field tag + size of length varint + string length
msg_size += 1 + api::ProtoSize::varint(static_cast<uint32_t>(line_length)) + line_length;
// Create a pre-sized buffer
auto buffer = this->create_buffer(); auto buffer = this->create_buffer();
// LogLevel level = 1; buffer.get_buffer()->reserve(msg_size);
buffer.encode_uint32(1, static_cast<uint32_t>(level));
// string message = 3; // Encode the message (SubscribeLogsResponse)
buffer.encode_string(3, line, strlen(line)); buffer.encode_uint32(1, static_cast<uint32_t>(level)); // LogLevel level = 1
buffer.encode_string(3, line, line_length); // string message = 3
// SubscribeLogsResponse - 29 // SubscribeLogsResponse - 29
return this->send_buffer(buffer, 29); return this->send_buffer(buffer, 29);
} }