From 926b42ba1cc9f2333bd58d0659c51d6cad1729a0 Mon Sep 17 00:00:00 2001 From: Jesse Hills <3060199+jesserockz@users.noreply.github.com> Date: Fri, 23 May 2025 11:33:38 +1200 Subject: [PATCH] [logger] Fix options in select (#8875) Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com> --- esphome/components/logger/__init__.py | 2 ++ esphome/components/logger/select/__init__.py | 9 +++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/esphome/components/logger/__init__.py b/esphome/components/logger/__init__.py index 2fc1601d28..1a4d645c8a 100644 --- a/esphome/components/logger/__init__.py +++ b/esphome/components/logger/__init__.py @@ -25,6 +25,7 @@ from esphome.const import ( CONF_HARDWARE_UART, CONF_ID, CONF_LEVEL, + CONF_LOGGER, CONF_LOGS, CONF_ON_MESSAGE, CONF_TAG, @@ -250,6 +251,7 @@ CONFIG_SCHEMA = cv.All( async def to_code(config): baud_rate = config[CONF_BAUD_RATE] level = config[CONF_LEVEL] + CORE.data.setdefault(CONF_LOGGER, {})[CONF_LEVEL] = level initial_level = LOG_LEVELS[config.get(CONF_INITIAL_LEVEL, level)] log = cg.new_Pvariable( config[CONF_ID], diff --git a/esphome/components/logger/select/__init__.py b/esphome/components/logger/select/__init__.py index b1fc881537..2e83599eb4 100644 --- a/esphome/components/logger/select/__init__.py +++ b/esphome/components/logger/select/__init__.py @@ -5,7 +5,7 @@ from esphome.const import CONF_LEVEL, CONF_LOGGER, ENTITY_CATEGORY_CONFIG, ICON_ from esphome.core import CORE from esphome.cpp_helpers import register_component, register_parented -from .. import CONF_LOGGER_ID, LOG_LEVEL_SEVERITY, Logger, logger_ns +from .. import CONF_LOGGER_ID, LOG_LEVELS, Logger, logger_ns CODEOWNERS = ["@clydebarrow"] @@ -21,9 +21,10 @@ CONFIG_SCHEMA = select.select_schema( async def to_code(config): - levels = LOG_LEVEL_SEVERITY - index = levels.index(CORE.config[CONF_LOGGER][CONF_LEVEL]) + parent = await cg.get_variable(config[CONF_LOGGER_ID]) + levels = list(LOG_LEVELS) + index = levels.index(CORE.data[CONF_LOGGER][CONF_LEVEL]) levels = levels[: index + 1] var = await select.new_select(config, options=levels) - await register_parented(var, config[CONF_LOGGER_ID]) + await register_parented(var, parent) await register_component(var, config)