jeans/esphome
jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-07-28 14:16:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CI] Use comment marker in too-big reviews (#9751)

Browse Source
This commit is contained in:
Jesse Hills 2025-07-21 13:33:20 +12:00 committed by GitHub
parent 9508871474
commit a8d53b7c68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
.github/workflows/auto-label-pr.yml vendored
View File

@ -14,7 +14,6 @@ env:
SMALL_PR_THRESHOLD: 30 SMALL_PR_THRESHOLD: 30
MAX_LABELS: 15 MAX_LABELS: 15
TOO_BIG_THRESHOLD: 1000 TOO_BIG_THRESHOLD: 1000
BOT_NAME: "esphome[bot]"
jobs: jobs:
label: label:
@ -59,6 +58,9 @@ jobs:
const { owner, repo } = context.repo; const { owner, repo } = context.repo;
const pr_number = context.issue.number; const pr_number = context.issue.number;
// Hidden marker to identify bot comments from this workflow
const BOT_COMMENT_MARKER = '<!-- auto-label-pr-bot -->';
// Get current labels // Get current labels
const { data: currentLabelsData } = await github.rest.issues.listLabelsOnIssue({ const { data: currentLabelsData } = await github.rest.issues.listLabelsOnIssue({
owner, owner,
@ -123,7 +125,6 @@ jobs:
const smallPrThreshold = parseInt('${{ env.SMALL_PR_THRESHOLD }}'); const smallPrThreshold = parseInt('${{ env.SMALL_PR_THRESHOLD }}');
const maxLabels = parseInt('${{ env.MAX_LABELS }}'); const maxLabels = parseInt('${{ env.MAX_LABELS }}');
const tooBigThreshold = parseInt('${{ env.TOO_BIG_THRESHOLD }}'); const tooBigThreshold = parseInt('${{ env.TOO_BIG_THRESHOLD }}');
const botName = process.env.BOT_NAME;
// Strategy: Merge to release or beta branch // Strategy: Merge to release or beta branch
const baseRef = context.payload.pull_request.base.ref; const baseRef = context.payload.pull_request.base.ref;
@ -401,11 +402,11 @@ jobs:
// Create appropriate review message // Create appropriate review message
let reviewBody; let reviewBody;
if (tooManyLabels && tooManyChanges) { if (tooManyLabels && tooManyChanges) {
reviewBody = `This PR is too large with ${totalChanges} line changes and affects ${originalLength} different components/areas. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`; reviewBody = `${BOT_COMMENT_MARKER}\nThis PR is too large with ${totalChanges} line changes and affects ${originalLength} different components/areas. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`;
} else if (tooManyLabels) { } else if (tooManyLabels) {
reviewBody = `This PR affects ${originalLength} different components/areas. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`; reviewBody = `${BOT_COMMENT_MARKER}\nThis PR affects ${originalLength} different components/areas. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`;
} else { } else {
reviewBody = `This PR is too large with ${totalChanges} line changes. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`; reviewBody = `${BOT_COMMENT_MARKER}\nThis PR is too large with ${totalChanges} line changes. Please consider breaking it down into smaller, focused PRs to make review easier and reduce the risk of conflicts.\n\nFor guidance on breaking down large PRs, see: https://developers.esphome.io/contributing/submitting-your-work/#but-howwww-looonnnggg`;
} }
// Request changes on the PR // Request changes on the PR
@ -432,13 +433,9 @@ jobs:
// Find bot reviews that requested changes // Find bot reviews that requested changes
const botReviews = reviews.filter(review => const botReviews = reviews.filter(review =>
review.user.login === botName && review.user.type === 'Bot' &&
review.state === 'CHANGES_REQUESTED' && review.state === 'CHANGES_REQUESTED' &&
review.body && ( review.body && review.body.includes(BOT_COMMENT_MARKER)
review.body.includes('This PR is too large') ||
review.body.includes('This PR affects') ||
review.body.includes('different components/areas')
)
); );
// Dismiss bot reviews // Dismiss bot reviews