address feedback

This commit is contained in:
J. Nick Koston 2025-07-11 14:12:03 -10:00
parent 869f96f832
commit c082ee616e
No known key found for this signature in database

View File

@ -379,7 +379,8 @@ class ProtoSize {
}
// Calculate and directly add to total_size
total_size += field_id_size + varint(static_cast<uint32_t>(str.size())) + str.size();
const uint32_t str_size = static_cast<uint32_t>(str.size());
total_size += field_id_size + varint(str_size) + str_size;
}
/**
@ -387,8 +388,8 @@ class ProtoSize {
*/
static inline void add_string_field_repeated(uint32_t &total_size, uint32_t field_id_size, const std::string &str) {
// Always calculate size for repeated fields
// No local variable needed for simple case
total_size += field_id_size + varint(static_cast<uint32_t>(str.size())) + str.size();
const uint32_t str_size = static_cast<uint32_t>(str.size());
total_size += field_id_size + varint(str_size) + str_size;
}
/**