jeans/esphome
jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-07-27 05:36:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'dev' into fix_missed_calculate_looping_components_

Browse Source
This commit is contained in:
J. Nick Koston 2025-07-22 15:51:47 -10:00 committed by GitHub
commit c400d8e5a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/codeowner-review-request.yml vendored
View File

@ -182,11 +182,14 @@ jobs:
}); });
// Check for previous comments from this workflow to avoid duplicate pings // Check for previous comments from this workflow to avoid duplicate pings
const { data: comments } = await github.rest.issues.listComments({ const comments = await github.paginate(
github.rest.issues.listComments,
{
owner, owner,
repo, repo,
issue_number: pr_number issue_number: pr_number
}); }
);
const previouslyPingedUsers = new Set(); const previouslyPingedUsers = new Set();
const previouslyPingedTeams = new Set(); const previouslyPingedTeams = new Set();
@ -194,7 +197,6 @@ jobs:
// Look for comments from github-actions bot that contain our bot marker // Look for comments from github-actions bot that contain our bot marker
const workflowComments = comments.filter(comment => const workflowComments = comments.filter(comment =>
comment.user.type === 'Bot' && comment.user.type === 'Bot' &&
comment.user.login === 'github-actions[bot]' &&
comment.body.includes(BOT_COMMENT_MARKER) comment.body.includes(BOT_COMMENT_MARKER)
); );

17
.github/workflows/issue-codeowner-notify.yml vendored
View File

@ -29,6 +29,9 @@ jobs:
console.log(`Processing issue #${issue_number} with label: ${labelName}`); console.log(`Processing issue #${issue_number} with label: ${labelName}`);
// Hidden marker to identify bot comments from this workflow
const BOT_COMMENT_MARKER = '<!-- issue-codeowner-notify-bot -->';
// Extract component name from label // Extract component name from label
const componentName = labelName.replace('component: ', ''); const componentName = labelName.replace('component: ', '');
console.log(`Component: ${componentName}`); console.log(`Component: ${componentName}`);
@ -93,11 +96,14 @@ jobs:
); );
// Check for previous comments from this workflow to avoid duplicate pings // Check for previous comments from this workflow to avoid duplicate pings
const { data: comments } = await github.rest.issues.listComments({ const comments = await github.paginate(
github.rest.issues.listComments,
{
owner, owner,
repo, repo,
issue_number: issue_number issue_number: issue_number
}); }
);
const previouslyPingedUsers = new Set(); const previouslyPingedUsers = new Set();
const previouslyPingedTeams = new Set(); const previouslyPingedTeams = new Set();
@ -105,9 +111,8 @@ jobs:
// Look for comments from github-actions bot that contain codeowner pings for this component // Look for comments from github-actions bot that contain codeowner pings for this component
const workflowComments = comments.filter(comment => const workflowComments = comments.filter(comment =>
comment.user.type === 'Bot' && comment.user.type === 'Bot' &&
comment.user.login === 'github-actions[bot]' && comment.body.includes(BOT_COMMENT_MARKER) &&
comment.body.includes(`component: ${componentName}`) && comment.body.includes(`component: ${componentName}`)
comment.body.includes("you've been identified as a codeowner")
); );
// Extract previously mentioned users and teams from workflow comments // Extract previously mentioned users and teams from workflow comments
@ -140,7 +145,7 @@ jobs:
// Create comment body // Create comment body
const mentionString = allMentions.join(', '); const mentionString = allMentions.join(', ');
const commentBody = `👋 Hey ${mentionString}!\n\nThis issue has been labeled with \`component: ${componentName}\` and you've been identified as a codeowner of this component. Please take a look when you have a chance!\n\nThanks for maintaining this component! 🙏`; const commentBody = `${BOT_COMMENT_MARKER}\n👋 Hey ${mentionString}!\n\nThis issue has been labeled with \`component: ${componentName}\` and you've been identified as a codeowner of this component. Please take a look when you have a chance!\n\nThanks for maintaining this component! 🙏`;
// Post comment // Post comment
await github.rest.issues.createComment({ await github.rest.issues.createComment({