From d60e1f02c0e11848d37447f559d277ec244068ee Mon Sep 17 00:00:00 2001 From: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com> Date: Thu, 8 May 2025 08:22:56 +1000 Subject: [PATCH] [packet_transport] Make some arguments const (#8700) Co-authored-by: clydeps --- esphome/components/packet_transport/packet_transport.cpp | 2 +- esphome/components/packet_transport/packet_transport.h | 5 ++--- esphome/components/uart/packet_transport/uart_transport.cpp | 2 +- esphome/components/uart/packet_transport/uart_transport.h | 2 +- esphome/components/udp/packet_transport/udp_transport.cpp | 2 +- esphome/components/udp/packet_transport/udp_transport.h | 2 +- esphome/components/udp/udp_component.h | 2 +- 7 files changed, 8 insertions(+), 9 deletions(-) diff --git a/esphome/components/packet_transport/packet_transport.cpp b/esphome/components/packet_transport/packet_transport.cpp index 4514584408..be2f77e379 100644 --- a/esphome/components/packet_transport/packet_transport.cpp +++ b/esphome/components/packet_transport/packet_transport.cpp @@ -353,7 +353,7 @@ static bool process_rolling_code(Provider &provider, PacketDecoder &decoder) { /** * Process a received packet */ -void PacketTransport::process_(std::vector &data) { +void PacketTransport::process_(const std::vector &data) { auto ping_key_seen = !this->ping_pong_enable_; PacketDecoder decoder((data.data()), data.size()); char namebuf[256]{}; diff --git a/esphome/components/packet_transport/packet_transport.h b/esphome/components/packet_transport/packet_transport.h index 6799cb6ea1..34edb82963 100644 --- a/esphome/components/packet_transport/packet_transport.h +++ b/esphome/components/packet_transport/packet_transport.h @@ -101,12 +101,12 @@ class PacketTransport : public PollingComponent { protected: // child classes must implement this - virtual void send_packet(std::vector &buf) const = 0; + virtual void send_packet(const std::vector &buf) const = 0; virtual size_t get_max_packet_size() = 0; virtual bool should_send() { return true; } // to be called by child classes when a data packet is received. - void process_(std::vector &data); + void process_(const std::vector &data); void send_data_(bool all); void flush_(); void add_data_(uint8_t key, const char *id, float data); @@ -146,7 +146,6 @@ class PacketTransport : public PollingComponent { const char *platform_name_{""}; void add_key_(const char *name, uint32_t key); void send_ping_pong_request_(); - void process_ping_request_(const char *name, uint8_t *ptr, size_t len); inline bool is_encrypted_() { return !this->encryption_key_.empty(); } }; diff --git a/esphome/components/uart/packet_transport/uart_transport.cpp b/esphome/components/uart/packet_transport/uart_transport.cpp index aa11ae0772..423b657532 100644 --- a/esphome/components/uart/packet_transport/uart_transport.cpp +++ b/esphome/components/uart/packet_transport/uart_transport.cpp @@ -74,7 +74,7 @@ void UARTTransport::write_byte_(uint8_t byte) const { this->parent_->write_byte(byte); } -void UARTTransport::send_packet(std::vector &buf) const { +void UARTTransport::send_packet(const std::vector &buf) const { this->parent_->write_byte(FLAG_BYTE); for (uint8_t byte : buf) { this->write_byte_(byte); diff --git a/esphome/components/uart/packet_transport/uart_transport.h b/esphome/components/uart/packet_transport/uart_transport.h index db32859452..f1431e948c 100644 --- a/esphome/components/uart/packet_transport/uart_transport.h +++ b/esphome/components/uart/packet_transport/uart_transport.h @@ -29,7 +29,7 @@ class UARTTransport : public packet_transport::PacketTransport, public UARTDevic protected: void write_byte_(uint8_t byte) const; - void send_packet(std::vector &buf) const override; + void send_packet(const std::vector &buf) const override; bool should_send() override { return true; }; size_t get_max_packet_size() override { return MAX_PACKET_SIZE; } std::vector receive_buffer_{}; diff --git a/esphome/components/udp/packet_transport/udp_transport.cpp b/esphome/components/udp/packet_transport/udp_transport.cpp index 3918760627..b92e0d64df 100644 --- a/esphome/components/udp/packet_transport/udp_transport.cpp +++ b/esphome/components/udp/packet_transport/udp_transport.cpp @@ -31,6 +31,6 @@ void UDPTransport::update() { this->resend_data_ = this->should_broadcast_; } -void UDPTransport::send_packet(std::vector &buf) const { this->parent_->send_packet(buf); } +void UDPTransport::send_packet(const std::vector &buf) const { this->parent_->send_packet(buf); } } // namespace udp } // namespace esphome diff --git a/esphome/components/udp/packet_transport/udp_transport.h b/esphome/components/udp/packet_transport/udp_transport.h index 5a27bc32c7..4a95a095cc 100644 --- a/esphome/components/udp/packet_transport/udp_transport.h +++ b/esphome/components/udp/packet_transport/udp_transport.h @@ -16,7 +16,7 @@ class UDPTransport : public packet_transport::PacketTransport, public Parented &buf) const override; + void send_packet(const std::vector &buf) const override; bool should_send() override; bool should_broadcast_{false}; size_t get_max_packet_size() override { return MAX_PACKET_SIZE; } diff --git a/esphome/components/udp/udp_component.h b/esphome/components/udp/udp_component.h index 25909eba1d..065789ae28 100644 --- a/esphome/components/udp/udp_component.h +++ b/esphome/components/udp/udp_component.h @@ -30,7 +30,7 @@ class UDPComponent : public Component { void loop() override; void dump_config() override; void send_packet(const uint8_t *data, size_t size); - void send_packet(std::vector &buf) { this->send_packet(buf.data(), buf.size()); } + void send_packet(const std::vector &buf) { this->send_packet(buf.data(), buf.size()); } float get_setup_priority() const override { return setup_priority::AFTER_WIFI; }; protected: