jeans/esphome
jeans/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-07-29 14:46:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize protobuf varint decoder for ESPHome use case (#8791)

Browse Source
This commit is contained in:
J. Nick Koston 2025-05-15 00:16:25 -05:00 committed by GitHub
parent dd8d8ad952
commit efa6745a5e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
esphome/components/api/proto.h
View File

@ -20,16 +20,26 @@ class ProtoVarInt {
explicit ProtoVarInt(uint64_t value) : value_(value) {} explicit ProtoVarInt(uint64_t value) : value_(value) {}
static optional<ProtoVarInt> parse(const uint8_t *buffer, uint32_t len, uint32_t *consumed) { static optional<ProtoVarInt> parse(const uint8_t *buffer, uint32_t len, uint32_t *consumed) {
if (consumed != nullptr) if (len == 0) {
*consumed = 0; if (consumed != nullptr)
*consumed = 0;
if (len == 0)
return {}; return {};
}
uint64_t result = 0; // Most common case: single-byte varint (values 0-127)
uint8_t bitpos = 0; if ((buffer[0] & 0x80) == 0) {
if (consumed != nullptr)
*consumed = 1;
return ProtoVarInt(buffer[0]);
}
for (uint32_t i = 0; i < len; i++) { // General case for multi-byte varints
// Since we know buffer[0]'s high bit is set, initialize with its value
uint64_t result = buffer[0] & 0x7F;
uint8_t bitpos = 7;
// Start from the second byte since we've already processed the first
for (uint32_t i = 1; i < len; i++) {
uint8_t val = buffer[i]; uint8_t val = buffer[i];
result |= uint64_t(val & 0x7F) << uint64_t(bitpos); result |= uint64_t(val & 0x7F) << uint64_t(bitpos);
bitpos += 7; bitpos += 7;
@ -40,7 +50,9 @@ class ProtoVarInt {
} }
} }
return {}; if (consumed != nullptr)
*consumed = 0;
return {}; // Incomplete or invalid varint
} }
uint32_t as_uint32() const { return this->value_; } uint32_t as_uint32() const { return this->value_; }