jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-28 13:46:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only append label if this exists in hero-icon

Browse Source 
Currently, an empty element was appended to hero-icon template to hold
the label even if this didn't exist, causing some vertical bottom
spacing.

We use Polymer's `dom-if` to conditional show this element. The label
was changed to be passed as an HTML property since it seems to be really
difficult to access the inner HTML of a polymer element programatically.
This commit is contained in:
Juan Cruz Viotti 2016-01-18 10:32:27 -04:00
parent 79b33cea1c
commit 0a8e89c782
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/components/hero-icon.html
View File

@ -14,11 +14,9 @@
</style>
<div class="icon"></div>
<div>
<hero-caption>
<content></content>
</hero-caption>
</div>
<template is="dom-if" if="{{label}}">
<hero-caption>{{label}}</hero-caption>
</template>
</template>
<script>
@ -31,6 +29,9 @@
path: {
type: String
},
label: {
type: String
},
width: {
type: String
},

6
lib/index.html
View File

@ -22,7 +22,7 @@
<div class="row around-xs space-bottom-large" ng-hide="app.writer.progress == 100 && !app.writer.isBurning()">
<div class="col-xs">
<div class="box text-center">
<hero-icon path="images/image.svg">SELECT IMAGE</hero-icon>
<hero-icon path="images/image.svg" label="SELECT IMAGE"></hero-icon>
<hero-badge class="block space-vertical-medium">1</hero-badge>
<div class="space-vertical-large">
@ -41,7 +41,7 @@
<div class="step-border-left" ng-disabled="!app.selection.hasImage()"></div>
<div class="step-border-right" ng-disabled="!app.selection.hasImage() || !app.selection.hasDrive()"></div>
<hero-icon path="images/drive.svg" ng-disabled="!app.selection.hasImage()">SELECT DRIVE</hero-icon>
<hero-icon path="images/drive.svg" ng-disabled="!app.selection.hasImage()" label="SELECT DRIVE"></hero-icon>
<hero-badge class="block space-vertical-medium" ng-disabled="!app.selection.hasImage()">2</hero-badge>
<div class="space-vertical-large">
@ -72,7 +72,7 @@
<div class="col-xs">
<div class="box text-center">
<hero-icon path="images/burn.svg" ng-disabled="!app.selection.hasImage() || !app.selection.hasDrive()">BURN IMAGE</hero-icon>
<hero-icon path="images/burn.svg" ng-disabled="!app.selection.hasImage() || !app.selection.hasDrive()" label="BURN IMAGE"></hero-icon>
<hero-badge class="block space-vertical-medium" ng-disabled="!app.selection.hasImage() || !app.selection.hasDrive()">3</hero-badge>
<div class="space-vertical-large">