From 12b5536e22457c69c33073b4b937bfa1a235aae5 Mon Sep 17 00:00:00 2001
From: Alexis Svinartchouk <alexis@resin.io>
Date: Tue, 14 Jan 2020 14:23:21 +0100
Subject: [PATCH] Don't webpack package.json as analytics tokens are interted
 after webpacking

Change-type: patch
---
 webpack.config.js | 37 ++++++++++++++++++++++++++++++++++---
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/webpack.config.js b/webpack.config.js
index 331ab0bd..d1714a91 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -16,10 +16,32 @@
 
 'use strict'
 
+const _ = require('lodash')
 const path = require('path')
 const SimpleProgressWebpackPlugin = require('simple-progress-webpack-plugin')
 const nodeExternals = require('webpack-node-externals')
 
+/**
+ * Don't webpack package.json as mixpanel & sentry tokens
+ * will be inserted in it after webpacking
+ *
+ * @param {*} packageJsonPath - Path for the package.json file
+ * @returns {void}
+ *
+ * @example webpack externals:
+ * [
+ *   externalPackageJson('./package.json')
+ * ]
+ */
+const externalPackageJson = (packageJsonPath) => {
+  return (_context, request, callback) => {
+    if (_.endsWith(request, 'package.json')) {
+      return callback(null, `commonjs ${packageJsonPath}`)
+    }
+    return callback()
+  }
+}
+
 const commonConfig = {
   mode: 'production',
   optimization: {
@@ -61,9 +83,6 @@ const commonConfig = {
       format: process.env.WEBPACK_PROGRESS || 'verbose'
     })
   ],
-  externals: [
-    nodeExternals()
-  ],
   output: {
     path: path.join(__dirname, 'generated'),
     filename: '[name].js'
@@ -77,6 +96,12 @@ const guiConfig = {
     __dirname: true,
     __filename: true
   },
+  externals: [
+    nodeExternals(),
+
+    // '../../../package.json' because we are in 'lib/gui/app/index.html'
+    externalPackageJson('../../../package.json')
+  ],
   entry: {
     gui: path.join(__dirname, 'lib', 'gui', 'app', 'app.js')
   },
@@ -90,6 +115,12 @@ const etcherConfig = {
     __dirname: false,
     __filename: true
   },
+  externals: [
+    nodeExternals(),
+
+    // '../package.json' because we are in 'generated/etcher.js'
+    externalPackageJson('../package.json')
+  ],
   entry: {
     etcher: path.join(__dirname, 'lib', 'start.js')
   }