From 1ae40c7b15eeffa59f0b38dae9ac5da2c661ddbb Mon Sep 17 00:00:00 2001 From: Benedict Aas Date: Thu, 18 Jan 2018 17:14:09 +0000 Subject: [PATCH] feat: test that ipc verbosity is off (#1963) feat: test that ipc verbosity is off We test that `ipc.config.silent` is set to `true` so that it doesn't spam `stdout` for users. Changelog-Entry: Test that IPC verbosity is off Change-Type: patch --- tests/gui/modules/child-writer.spec.js | 27 ++++++++++++++++++++++++++ tests/gui/modules/image-writer.spec.js | 10 ++++++++++ 2 files changed, 37 insertions(+) create mode 100644 tests/gui/modules/child-writer.spec.js diff --git a/tests/gui/modules/child-writer.spec.js b/tests/gui/modules/child-writer.spec.js new file mode 100644 index 00000000..351a5596 --- /dev/null +++ b/tests/gui/modules/child-writer.spec.js @@ -0,0 +1,27 @@ +/* + * Copyright 2018 resin.io + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +'use strict' + +const m = require('mochainon') +const ipc = require('node-ipc') +require('../../../lib/gui/modules/child-writer') + +describe('Browser: childWriter', function () { + it('should have the ipc config set to silent', function () { + m.chai.expect(ipc.config.silent).to.be.true + }) +}) diff --git a/tests/gui/modules/image-writer.spec.js b/tests/gui/modules/image-writer.spec.js index 234ab1d0..36131cbe 100644 --- a/tests/gui/modules/image-writer.spec.js +++ b/tests/gui/modules/image-writer.spec.js @@ -1,6 +1,7 @@ 'use strict' const m = require('mochainon') +const ipc = require('node-ipc') const angular = require('angular') const Bluebird = require('bluebird') const flashState = require('../../../lib/shared/models/flash-state') @@ -100,4 +101,13 @@ describe('Browser: imageWriter', () => { }) }) }) + + describe('.performWrite()', function () { + it('should set the ipc config to silent', function () { + // Reset this value as it can persist from other tests + ipc.config.silent = false + imageWriter.performWrite(undefined, undefined, undefined).cancel() + m.chai.expect(ipc.config.silent).to.be.true + }) + }) })