From 23a5e53d50ae8fe1ecd5fa4915fd923947a88182 Mon Sep 17 00:00:00 2001
From: Juan Cruz Viotti <jviotti@openmailbox.org>
Date: Wed, 26 Apr 2017 11:05:36 -0400
Subject: [PATCH] refactor: address review comments from #1351 (#1355)

See: https://github.com/resin-io/etcher/pull/1351
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
---
 lib/child-writer/writer-proxy.js |  2 +-
 tests/shared/permissions.spec.js | 24 ++++++++++++------------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/lib/child-writer/writer-proxy.js b/lib/child-writer/writer-proxy.js
index 30b6113a..c74a250d 100644
--- a/lib/child-writer/writer-proxy.js
+++ b/lib/child-writer/writer-proxy.js
@@ -1,5 +1,5 @@
 /*
- * Copyright 2017 resin.io
+ * Copyright 2016 resin.io
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
diff --git a/tests/shared/permissions.spec.js b/tests/shared/permissions.spec.js
index 559eed23..20f4816f 100644
--- a/tests/shared/permissions.spec.js
+++ b/tests/shared/permissions.spec.js
@@ -39,7 +39,7 @@ describe('Shared: permissions', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix()).to.deep.equal([]);
       });
 
-      it('should return an empty array environment is an empty object', function() {
+      it('should return an empty array if the environment is an empty object', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({})).to.deep.equal([]);
       });
 
@@ -76,11 +76,11 @@ describe('Shared: permissions', function() {
       it('should ignore undefined and null variable values', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({
           FOO: null,
-          BAR: undefined,
-          BAZ: 'qux'
+          BAR: 'qux',
+          BAZ: undefined
         })).to.deep.equal([
           'set',
-          'BAZ=qux',
+          'BAR=qux',
           '&&',
           'call'
         ]);
@@ -122,7 +122,7 @@ describe('Shared: permissions', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix()).to.deep.equal([]);
       });
 
-      it('should return an empty array environment is an empty object', function() {
+      it('should return an empty array if the environment is an empty object', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({})).to.deep.equal([]);
       });
 
@@ -151,11 +151,11 @@ describe('Shared: permissions', function() {
       it('should ignore undefined and null variable values', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({
           FOO: null,
-          BAR: undefined,
-          BAZ: 'qux'
+          BAR: 'qux',
+          BAZ: undefined
         })).to.deep.equal([
           'env',
-          'BAZ=qux'
+          'BAR=qux'
         ]);
       });
 
@@ -189,7 +189,7 @@ describe('Shared: permissions', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix()).to.deep.equal([]);
       });
 
-      it('should return an empty array environment is an empty object', function() {
+      it('should return an empty array if the environment is an empty object', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({})).to.deep.equal([]);
       });
 
@@ -218,11 +218,11 @@ describe('Shared: permissions', function() {
       it('should ignore undefined and null variable values', function() {
         m.chai.expect(permissions.getEnvironmentCommandPrefix({
           FOO: null,
-          BAR: undefined,
-          BAZ: 'qux'
+          BAR: 'qux',
+          BAZ: undefined
         })).to.deep.equal([
           'env',
-          'BAZ=qux'
+          'BAR=qux'
         ]);
       });