From 24f442a8fca0b8bd73cb603adee1d1027114c433 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Wed, 22 Jun 2016 10:40:45 -0400 Subject: [PATCH] docs(MAINTAINERS.md): steps to upgrade electron (#501) This PR documents the process to upgrade the Electron version correctly, in order to prevent any potential compatibility issue when building native dependencies. Signed-off-by: Juan Cruz Viotti --- docs/MAINTAINERS.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/MAINTAINERS.md b/docs/MAINTAINERS.md index 04ccd076..0e2b1086 100644 --- a/docs/MAINTAINERS.md +++ b/docs/MAINTAINERS.md @@ -40,3 +40,14 @@ git tag -a v1.0.0 -m "v1.0.0" git push git push --tags ``` + +Upgrading Electron +------------------ + +- Upgrade the `electron-prebuilt` dependency version in `package.json` to an *exact version* (no `~`, `^`, etc). + +- Find the exact NodeJS version included in the desired Electron version and update `engines.node` in `package.json` appropriately. This can be usually found in the [Electron releases page](https://github.com/electron/electron/releases). + +- Update the `NODE_VERSION` environment variable in `.travis.yml`. + +- Update the `nodejs_version` and `npm_config_target` environment variables in `appveyor.yml`.