jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-25 20:26:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: apply REMOVE_DRIVE recursively in SET_AVAILABLE_DRIVES (#515)

Browse Source 
We were duplicating the remove drive logic in the `SET_AVAILABLE_DRIVES`
case when the currently selected drive didn't exist anymore.

A better way to handle this without coding repetition is to recursively
apply the reduced with the new state.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-06-23 11:20:10 -04:00 committed by GitHub
parent c2c5eb59b9
commit 2b9f0b5003
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/gui/models/store.js
View File

@ -38,7 +38,7 @@ const DEFAULT_STATE = Immutable.fromJS({
} }
}); });
module.exports = redux.createStore(function(state, action) { const store = function(state, action) {
state = state || DEFAULT_STATE; state = state || DEFAULT_STATE;
switch (action.type) { switch (action.type) {
@ -58,7 +58,9 @@ module.exports = redux.createStore(function(state, action) {
if (selectedDevice && !_.find(action.data, { if (selectedDevice && !_.find(action.data, {
device: selectedDevice device: selectedDevice
})) { })) {
return newState.deleteIn([ 'selection', 'drive' ]); return store(newState, {
type: 'REMOVE_DRIVE'
});
} }
return newState; return newState;
@ -150,4 +152,6 @@ module.exports = redux.createStore(function(state, action) {
} }
} }
}); };
module.exports = redux.createStore(store);