From 311dcd27a886547e28f7983609cf250d0b3b3cc0 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Mon, 27 Feb 2017 17:06:02 -0400 Subject: [PATCH] chore: add missing `:` after options in publish scripts (#1134) Not including the colon means that the option parsing mechanism is not expecting an argument for the `-t` and the `-p` option (for `bintray-debian.sh` and `aws-s3.sh` respectively), and thus `$OPTARG` will be undefined. Signed-off-by: Juan Cruz Viotti --- scripts/publish/aws-s3.sh | 2 +- scripts/publish/bintray-debian.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/publish/aws-s3.sh b/scripts/publish/aws-s3.sh index 4805cb44..5bda286a 100755 --- a/scripts/publish/aws-s3.sh +++ b/scripts/publish/aws-s3.sh @@ -39,7 +39,7 @@ ARGV_BUCKET="" ARGV_VERSION="" ARGV_PRODUCT_NAME="" -while getopts ":f:b:v:p" option; do +while getopts ":f:b:v:p:" option; do case $option in f) ARGV_FILE="$OPTARG" ;; b) ARGV_BUCKET="$OPTARG" ;; diff --git a/scripts/publish/bintray-debian.sh b/scripts/publish/bintray-debian.sh index 41f218e6..7772c271 100755 --- a/scripts/publish/bintray-debian.sh +++ b/scripts/publish/bintray-debian.sh @@ -41,7 +41,7 @@ ARGV_ARCHITECTURE="" ARGV_COMPONENT_NAME="" ARGV_RELEASE_TYPE="" -while getopts ":f:v:r:c:t" option; do +while getopts ":f:v:r:c:t:" option; do case $option in f) ARGV_FILE="$OPTARG" ;; v) ARGV_VERSION="$OPTARG" ;;