jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-27 21:26:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove body display hidden white flash workaround (#478)

Browse Source 
In older versions of Electron, the application would display a quick
flash of white before running caused by the WebView loading up.

This workaround doesn't seem necessary anymore.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-06-13 10:58:01 -04:00 committed by GitHub
parent 3d921f2f86
commit 34ab982b24
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/gui/app.js
View File

@ -179,16 +179,6 @@ app.controller('AppController', function(
} }
}); });
// We manually add `style="display: none;"` to <body>
// and unset it here instead of using ngCloak since
// the latter takes effect as soon as the Angular
// library was loaded, but doesn't always mean that
// the application is ready, causing the application
// to be shown in an unitialized state for some milliseconds.
// Here in the controller, we are sure things are
// completely up and running.
document.querySelector('body').style.display = 'initial';
this.selectImage = function(image) { this.selectImage = function(image) {
if (!SupportedFormatsModel.isSupportedImage(image.path)) { if (!SupportedFormatsModel.isSupportedImage(image.path)) {
AnalyticsService.logEvent('Invalid image', image); AnalyticsService.logEvent('Invalid image', image);

2
lib/gui/index.html
View File

@ -17,7 +17,7 @@
<script src="./app.js"></script> <script src="./app.js"></script>
</head> </head>
<body ng-app="Etcher" style="display: none"> <body ng-app="Etcher">
<header class="section-header"> <header class="section-header">
<button class="btn btn-link" os-open-external="https://github.com/resin-io/etcher/blob/master/SUPPORT.md"> <button class="btn btn-link" os-open-external="https://github.com/resin-io/etcher/blob/master/SUPPORT.md">
<span class="glyphicon glyphicon-question-sign"></span> Need Help? <span class="glyphicon glyphicon-question-sign"></span> Need Help?