jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 07:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't throw if state percentage is zero (#536)

Browse Source 
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-06-27 16:15:35 -04:00 committed by GitHub
parent 74d436f4f5
commit 3bf712b592
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/gui/models/store.js
View File

@ -133,7 +133,7 @@ const storeReducer = (state, action) => {
throw new Error(`Invalid state type: ${action.data.type}`);
}
if (!action.data.percentage) {
if (_.isUndefined(action.data.percentage) || _.isNull(action.data.percentage)) {
throw new Error('Missing state percentage');
}

12
tests/gui/modules/image-writer.spec.js
View File

@ -120,6 +120,18 @@ describe('Browser: ImageWriter', function() {
}).to.throw('Invalid state type: 1234');
});
it('should not throw if percentage is 0', function() {
ImageWriterService.setFlashingFlag();
m.chai.expect(function() {
ImageWriterService.setProgressState({
type: 'write',
percentage: 0,
eta: 15,
speed: 100000000000
});
}).to.not.throw('Missing state percentage');
});
it('should throw if percentage is missing', function() {
ImageWriterService.setFlashingFlag();
m.chai.expect(function() {