refactor: move most models to lib/shared/ (#1596)

Now that the Redux store is no longer front-end dependent, we can move
most of the models to lib/shared. Currently, lib/shared is a mess, and
contains all sorts of functionality, however moving things out of the
GUI is the first step. Once we have everything decoupled, we can
organise all the code we have there.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
This commit is contained in:
Juan Cruz Viotti 2017-07-18 12:34:10 -03:00 committed by GitHub
parent 3a42331875
commit 4122e0bf1d
17 changed files with 80 additions and 36 deletions

View File

@ -35,13 +35,13 @@ const s3Packages = require('../shared/s3-packages');
const release = require('../shared/release'); const release = require('../shared/release');
const store = require('../shared/store'); const store = require('../shared/store');
const packageJSON = require('../../package.json'); const packageJSON = require('../../package.json');
const flashState = require('./models/flash-state'); const flashState = require('../shared/models/flash-state');
const settings = require('./models/settings'); const settings = require('./models/settings');
const windowProgress = require('./os/window-progress'); const windowProgress = require('./os/window-progress');
const analytics = require('./modules/analytics'); const analytics = require('./modules/analytics');
const updateNotifier = require('./components/update-notifier'); const updateNotifier = require('./components/update-notifier');
const availableDrives = require('./models/available-drives'); const availableDrives = require('../shared/models/available-drives');
const selectionState = require('./models/selection-state'); const selectionState = require('../shared/models/selection-state');
const driveScanner = require('./modules/drive-scanner'); const driveScanner = require('./modules/drive-scanner');
const osDialog = require('./os/dialog'); const osDialog = require('./os/dialog');
const exceptionReporter = require('./modules/exception-reporter'); const exceptionReporter = require('./modules/exception-reporter');

View File

@ -21,8 +21,8 @@ const _ = require('lodash');
const messages = require('../../../../shared/messages'); const messages = require('../../../../shared/messages');
const constraints = require('../../../../shared/drive-constraints'); const constraints = require('../../../../shared/drive-constraints');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
const availableDrives = require('../../../models/available-drives'); const availableDrives = require('../../../../shared/models/available-drives');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
module.exports = function( module.exports = function(
$q, $q,

View File

@ -16,8 +16,8 @@
'use strict'; 'use strict';
const flashState = require('../../../models/flash-state'); const flashState = require('../../../../shared/models/flash-state');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
module.exports = function(WarningModalService) { module.exports = function(WarningModalService) {

View File

@ -24,7 +24,7 @@ const angular = require('angular');
const _ = require('lodash'); const _ = require('lodash');
const childWriter = require('../../child-writer'); const childWriter = require('../../child-writer');
const settings = require('../models/settings'); const settings = require('../models/settings');
const flashState = require('../models/flash-state'); const flashState = require('../../shared/models/flash-state');
const windowProgress = require('../os/window-progress'); const windowProgress = require('../os/window-progress');
const analytics = require('../modules/analytics'); const analytics = require('../modules/analytics');

View File

@ -17,8 +17,8 @@
'use strict'; 'use strict';
const settings = require('../../../models/settings'); const settings = require('../../../models/settings');
const flashState = require('../../../models/flash-state'); const flashState = require('../../../../shared/models/flash-state');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
module.exports = function($state) { module.exports = function($state) {

View File

@ -17,7 +17,7 @@
'use strict'; 'use strict';
const settings = require('../../../models/settings'); const settings = require('../../../models/settings');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
const exceptionReporter = require('../../../modules/exception-reporter'); const exceptionReporter = require('../../../modules/exception-reporter');

View File

@ -18,7 +18,7 @@
const messages = require('../../../../shared/messages'); const messages = require('../../../../shared/messages');
const settings = require('../../../models/settings'); const settings = require('../../../models/settings');
const flashState = require('../../../models/flash-state'); const flashState = require('../../../../shared/models/flash-state');
const driveScanner = require('../../../modules/drive-scanner'); const driveScanner = require('../../../modules/drive-scanner');
const utils = require('../../../../shared/utils'); const utils = require('../../../../shared/utils');
const notification = require('../../../os/notification'); const notification = require('../../../os/notification');

View File

@ -24,7 +24,7 @@ const errors = require('../../../../shared/errors');
const imageStream = require('../../../../image-stream'); const imageStream = require('../../../../image-stream');
const supportedFormats = require('../../../../shared/supported-formats'); const supportedFormats = require('../../../../shared/supported-formats');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
const osDialog = require('../../../os/dialog'); const osDialog = require('../../../os/dialog');
const exceptionReporter = require('../../../modules/exception-reporter'); const exceptionReporter = require('../../../modules/exception-reporter');

View File

@ -17,11 +17,11 @@
'use strict'; 'use strict';
const settings = require('../../../models/settings'); const settings = require('../../../models/settings');
const flashState = require('../../../models/flash-state'); const flashState = require('../../../../shared/models/flash-state');
const analytics = require('../../../modules/analytics'); const analytics = require('../../../modules/analytics');
const exceptionReporter = require('../../../modules/exception-reporter'); const exceptionReporter = require('../../../modules/exception-reporter');
const availableDrives = require('../../../models/available-drives'); const availableDrives = require('../../../../shared/models/available-drives');
const selectionState = require('../../../models/selection-state'); const selectionState = require('../../../../shared/models/selection-state');
module.exports = function( module.exports = function(
TooltipModalService, TooltipModalService,

View File

@ -17,7 +17,7 @@
'use strict'; 'use strict';
const _ = require('lodash'); const _ = require('lodash');
const store = require('../../shared/store'); const store = require('../store');
/** /**
* @summary Check if there are available drives * @summary Check if there are available drives

View File

@ -16,13 +16,9 @@
'use strict'; 'use strict';
/**
* @module Etcher.Models.FlashState
*/
const _ = require('lodash'); const _ = require('lodash');
const store = require('../../shared/store'); const store = require('../store');
const units = require('../../shared/units'); const units = require('../units');
/** /**
* @summary Reset flash state * @summary Reset flash state

View File

@ -17,7 +17,7 @@
'use strict'; 'use strict';
const _ = require('lodash'); const _ = require('lodash');
const store = require('../../shared/store'); const store = require('../store');
const availableDrives = require('./available-drives'); const availableDrives = require('./available-drives');
/** /**

View File

@ -2,7 +2,7 @@
const m = require('mochainon'); const m = require('mochainon');
const angular = require('angular'); const angular = require('angular');
const flashState = require('../../../lib/gui/models/flash-state'); const flashState = require('../../../lib/shared/models/flash-state');
require('angular-mocks'); require('angular-mocks');
describe('Browser: ImageWriter', function() { describe('Browser: ImageWriter', function() {

View File

@ -6,9 +6,9 @@ const path = require('path');
const supportedFormats = require('../../../lib/shared/supported-formats'); const supportedFormats = require('../../../lib/shared/supported-formats');
const angular = require('angular'); const angular = require('angular');
const settings = require('../../../lib/gui/models/settings'); const settings = require('../../../lib/gui/models/settings');
const flashState = require('../../../lib/gui/models/flash-state'); const flashState = require('../../../lib/shared/models/flash-state');
const availableDrives = require('../../../lib/gui/models/available-drives'); const availableDrives = require('../../../lib/shared/models/available-drives');
const selectionState = require('../../../lib/gui/models/selection-state'); const selectionState = require('../../../lib/shared/models/selection-state');
require('angular-mocks'); require('angular-mocks');
describe('Browser: MainPage', function() { describe('Browser: MainPage', function() {

View File

@ -1,11 +1,27 @@
/*
* Copyright 2016 resin.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict'; 'use strict';
const m = require('mochainon'); const m = require('mochainon');
const path = require('path'); const path = require('path');
const availableDrives = require('../../../lib/gui/models/available-drives'); const availableDrives = require('../../../lib/shared/models/available-drives');
const selectionState = require('../../../lib/gui/models/selection-state'); const selectionState = require('../../../lib/shared/models/selection-state');
describe('Browser: availableDrives', function() { describe('Model: availableDrives', function() {
describe('availableDrives', function() { describe('availableDrives', function() {

View File

@ -1,9 +1,25 @@
/*
* Copyright 2016 resin.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict'; 'use strict';
const m = require('mochainon'); const m = require('mochainon');
const flashState = require('../../../lib/gui/models/flash-state'); const flashState = require('../../../lib/shared/models/flash-state');
describe('Browser: flashState', function() { describe('Model: flashState', function() {
beforeEach(function() { beforeEach(function() {
flashState.resetState(); flashState.resetState();

View File

@ -1,12 +1,28 @@
/*
* Copyright 2016 resin.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict'; 'use strict';
const m = require('mochainon'); const m = require('mochainon');
const _ = require('lodash'); const _ = require('lodash');
const path = require('path'); const path = require('path');
const availableDrives = require('../../../lib/gui/models/available-drives'); const availableDrives = require('../../../lib/shared/models/available-drives');
const selectionState = require('../../../lib/gui/models/selection-state'); const selectionState = require('../../../lib/shared/models/selection-state');
describe('Browser: selectionState', function() { describe('Model: selectionState', function() {
describe('given a clean state', function() { describe('given a clean state', function() {