jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-23 11:16:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(image-stream): return a path from the handler (#1278)

Browse Source 
The `application/x-apple-diskimage` handler doesn't return a path,
causing an issue when fetching the image metadata, and trying using the
path to determine if its a supported image type.

Change-Type: patch
Changelog-Entry: Fix "Path must be a string. Received undefined" when selecting Apple images.
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2017-04-10 23:49:22 -04:00 committed by GitHub
parent fc46958ac0
commit 44094680fb
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/image-stream/handlers.js
View File

@ -142,6 +142,7 @@ module.exports = {
'application/x-apple-diskimage': (file, options) => { 'application/x-apple-diskimage': (file, options) => {
return udif.getUncompressedSizeAsync(file).then((size) => { return udif.getUncompressedSizeAsync(file).then((size) => {
return { return {
path: file,
stream: udif.createReadStream(file), stream: udif.createReadStream(file),
size: { size: {
original: options.size, original: options.size,

2
tests/image-stream/dmg.spec.js
View File

@ -50,6 +50,7 @@ describe('ImageStream: DMG', function() {
return imageStream.getImageMetadata(image).then((metadata) => { return imageStream.getImageMetadata(image).then((metadata) => {
m.chai.expect(metadata).to.deep.equal({ m.chai.expect(metadata).to.deep.equal({
path: image,
size: { size: {
original: compressedSize, original: compressedSize,
final: { final: {
@ -86,6 +87,7 @@ describe('ImageStream: DMG', function() {
return imageStream.getImageMetadata(image).then((metadata) => { return imageStream.getImageMetadata(image).then((metadata) => {
m.chai.expect(metadata).to.deep.equal({ m.chai.expect(metadata).to.deep.equal({
path: image,
size: { size: {
original: compressedSize, original: compressedSize,
final: { final: {