style(GUI): say "eject" instead of "unmount" in Windows (#754)

In Windows, if the user unmounts a drive, then the drive becomes
inaccessible to the OS. Compare this to UNIX based operating systems,
where an unmounted drive is still available for many I/O operations.

To prevent confusion, we say "eject" instead of "unmount" when running
on Windows, despite "unmount" being the correct way of saying it.

See: https://github.com/resin-io/etcher/issues/750
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-10-07 15:32:04 -03:00 committed by GitHub
parent c8ae05949c
commit 4e5b000440
2 changed files with 20 additions and 1 deletions

View File

@ -16,8 +16,18 @@
'use strict';
const os = require('os');
module.exports = function(WarningModalService, SettingsModel) {
/**
* @summary Client platform
* @type String
* @constant
* @public
*/
this.platform = os.platform();
/**
* @summary Refresh current settings
* @function

View File

@ -17,7 +17,16 @@
ng-model="settings.currentData.unmountOnSuccess"
ng-change="settings.model.set('unmountOnSuccess', settings.currentData.unmountOnSuccess)">
<span>Auto-unmount on success</span>
<!-- On Windows, "Unmounting" basically means "ejecting". -->
<!-- On top of that, Windows users are usually not even -->
<!-- familiar with the meaning of "unmount", which comes -->
<!-- from the UNIX world. -->
<span>
<span ng-show="settings.platform == 'win32'">Eject</span>
<span ng-hide="settings.platform == 'win32'">Auto-unmount</span>
on success
</span>
</label>
</div>