jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 23:37:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use SettingsService in FinishController

Browse Source 
EXposing the settings from the `FinishController` is a better approach
that instantiating the `SettingsController` in the Finish page template.
This commit is contained in:
Juan Cruz Viotti 2016-04-01 09:04:55 -04:00
parent 6a11232eea
commit 4ef7dae3c4
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/browser/pages/finish/controllers/finish.js
View File

@ -16,7 +16,14 @@
'use strict';
module.exports = function($state, SelectionStateService, ImageWriterService, AnalyticsService) {
module.exports = function($state, SelectionStateService, ImageWriterService, AnalyticsService, SettingsService) {
/**
* @summary Settings data
* @type Object
* @public
*/
this.settings = SettingsService.data;
/**
* @summary Restart the burning process

4
lib/browser/pages/finish/templates/success.tpl.html
View File

@ -2,9 +2,7 @@
<div class="col-xs">
<div class="box text-center">
<h3><span class="tick tick--success" class="space-right-tiny"></span> Burn Complete!</h3>
<p class="soft"
ng-controller="SettingsController as settings"
ng-show="settings.storage.unmountOnSuccess">Safely ejected and ready for use</p>
<p class="soft" ng-show="finish.settings.unmountOnSuccess">Safely ejected and ready for use</p>
<div class="row center-xs space-vertical-large">
<div class="col-xs-4 space-medium">