From 4f87079f124d301dc1fdd60d584e8d9e0e2084ed Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 23 Jun 2017 18:59:15 -0400 Subject: [PATCH] chore: make use of electron-builder for the package-electron target (#1540) This target builds a package for the current operating system, but doesn't create an installer out of it, which is useful for debugging purposes. Change-Type: patch Signed-off-by: Juan Cruz Viotti --- Makefile | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a56959a5..d99e6b6a 100644 --- a/Makefile +++ b/Makefile @@ -163,6 +163,7 @@ endif ifdef DISABLE_UPDATES $(warning Update notification dialog has been disabled (DISABLE_UPDATES is set)) +ELECTRON_BUILDER_OPTIONS += --extraMetadata.updates.enabled=false endif # --------------------------------------------------------------------- @@ -433,7 +434,14 @@ TARGETS = \ installers-all \ electron-develop -package-electron: $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-$(APPLICATION_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH) +package-electron: + CSC_NAME="$(CODE_SIGN_IDENTITY)" \ + CSC_IDENTITY_AUTO_DISCOVERY=false \ + CSC_LINK=$(CODE_SIGN_CERTIFICATE) \ + CSC_KEY_PASSWORD=$(CODE_SIGN_CERTIFICATE_PASSWORD) \ + TARGET_ARCH=$(TARGET_ARCH) \ + $(NPX) build --dir $(ELECTRON_BUILDER_OPTIONS) + package-cli: $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(TARGET_PLATFORM)-$(TARGET_ARCH) ifeq ($(TARGET_PLATFORM),darwin)