jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-22 18:56:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: download files to a temporary filename first, then rename (#973)

Browse Source 
This avoids the failure-mode where wget got interrupted (e.g. network error
or server timeout), which caused the download-tool.sh to stop, which caused
the current make to stop. However if you then ran make again, it would see
that the file existed (and not know that it was incomplete / corrupt) and so
not try downloading it again. This commit fixes the problem by modifying
download-tool.sh to download to a temporary filename, and only rename to the
final destination filename after the checksum has been verified.
This commit is contained in:
Andrew Scheller 2016-12-12 20:46:27 +00:00 committed by Juan Cruz Viotti
parent 07713fe6b1
commit 50b69ad06b
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/build/download-tool.sh
View File

@ -63,7 +63,13 @@ function checksum_matches() {
test "$($SHA256SUM $file | cut -d ' ' -f1)" = "$hash" test "$($SHA256SUM $file | cut -d ' ' -f1)" = "$hash"
} }
if [ -e "$ARGV_OUTPUT" ]; then TEMP_OUTPUT="$ARGV_OUTPUT.TMP"
if [ -f "$TEMP_OUTPUT" ]; then
rm "$TEMP_OUTPUT"
fi
if [ -f "$ARGV_OUTPUT" ]; then
if checksum_matches "$ARGV_OUTPUT" "$ARGV_CHECKSUM"; then if checksum_matches "$ARGV_OUTPUT" "$ARGV_CHECKSUM"; then
echo "Re-using from cache" echo "Re-using from cache"
exit 0 exit 0
@ -72,12 +78,14 @@ if [ -e "$ARGV_OUTPUT" ]; then
fi fi
fi fi
wget --no-check-certificate "$ARGV_URL" -O "$ARGV_OUTPUT" wget --no-check-certificate "$ARGV_URL" -O "$TEMP_OUTPUT"
if ! checksum_matches "$ARGV_OUTPUT" "$ARGV_CHECKSUM"; then if ! checksum_matches "$TEMP_OUTPUT" "$ARGV_CHECKSUM"; then
echo "Checksum mismatch" 1>&2 echo "Checksum mismatch" 1>&2
rm -f "$ARGV_OUTPUT" rm "$TEMP_OUTPUT"
exit 1 exit 1
else
mv "$TEMP_OUTPUT" "$ARGV_OUTPUT"
fi fi
if [ "$ARGV_EXECUTE_PERMISSIONS" == "true" ]; then if [ "$ARGV_EXECUTE_PERMISSIONS" == "true" ]; then