jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 07:17:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): Remove throw if no percentage or eta test

Browse Source 
Since 25916200f2864a9b137325f919c0f8ef5d62fa60 we can handle a progress
state with no percentage or eta.
This commit is contained in:
Alexis Svinartchouk 2018-08-29 14:29:50 +02:00
parent 6b270885bf
commit 63967d1558
2 changed files with 15 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/gui/app/models/store.js
View File

@ -24,6 +24,7 @@ const constraints = require('../../../shared/drive-constraints')
const supportedFormats = require('../../../shared/supported-formats')
const errors = require('../../../shared/errors')
const fileExtensions = require('../../../shared/file-extensions')
const utils = require('../../../shared/utils')
const settings = require('./settings')
/**
@ -250,6 +251,20 @@ const storeReducer = (state = DEFAULT_STATE, action) => {
})
}
if (action.data.percentage !== undefined) {
if (!utils.isValidPercentage(action.data.percentage)) {
throw errors.createError({
title: `Invalid state percentage: ${action.data.percentage}`
})
}
if (!_.isNumber(action.data.eta)) {
throw errors.createError({
title: `Invalid state eta: ${action.data.eta}`
})
}
}
return state.set('flashState', Immutable.fromJS(action.data))
}

32
tests/gui/models/flash-state.spec.js
View File

@ -126,22 +126,6 @@ describe('Model: flashState', function () {
}).to.not.throw('Missing flash fields: percentage')
})
it('should throw if percentage is missing', function () {
flashState.setFlashingFlag()
m.chai.expect(function () {
flashState.setProgressState({
flashing: 2,
verifying: 0,
successful: 0,
failed: 0,
type: 'write',
eta: 15,
speed: 100000000000,
totalSpeed: 200000000000
})
}).to.throw('Missing flash fields: percentage')
})
it('should throw if percentage is not a number', function () {
flashState.setFlashingFlag()
m.chai.expect(function () {
@ -193,22 +177,6 @@ describe('Model: flashState', function () {
}).to.throw('Invalid state percentage: -1')
})
it('should throw if eta is missing', function () {
flashState.setFlashingFlag()
m.chai.expect(function () {
flashState.setProgressState({
flashing: 2,
verifying: 0,
successful: 0,
failed: 0,
type: 'write',
percentage: 50,
speed: 100000000000,
totalSpeed: 200000000000
})
}).to.throw('Missing flash fields: eta')
})
it('should not throw if eta is equal to zero', function () {
flashState.setFlashingFlag()
m.chai.expect(function () {