jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-23 19:26:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2156 from resin-io/fix-store-quantity-guards

Browse Source 
fix: ensure flash quantity fields are finite
This commit is contained in:
Jonas Hermsmeier 2018-04-05 18:54:05 +02:00 committed by GitHub
commit 64604dbcc6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/shared/store.js
View File

@ -246,14 +246,14 @@ const storeReducer = (state = DEFAULT_STATE, action) => {
verifyNoNilFields(action.data, flashStateNoNilFields, 'flash')
if (_.every(_.pick(action.data, [
if (!_.every(_.pick(action.data, [
'flashing',
'verifying',
'succeeded',
'failed'
]), _.identity)) {
]), _.isFinite)) {
throw errors.createError({
title: 'Missing state quantity field(s)'
title: 'State quantity field(s) not finite number'
})
}

34
tests/shared/models/flash-state.spec.js
View File

@ -29,7 +29,7 @@ describe('Model: flashState', function () {
it('should be able to reset the progress state', function () {
flashState.setFlashingFlag()
flashState.setProgressState({
flashing: 0,
flashing: 2,
verifying: 0,
succeeded: 0,
failed: 0,
@ -325,6 +325,38 @@ describe('Model: flashState', function () {
m.chai.expect(flashState.getFlashState().percentage).to.equal(50)
})
it('should error when any field is non-nil but not a finite number', function () {
m.chai.expect(() => {
flashState.setFlashingFlag()
flashState.setProgressState({
flashing: {},
verifying: [],
succeeded: true,
failed: 'string',
percentage: 0,
eta: 0,
speed: 0,
totalSpeed: 0
})
}).to.throw('State quantity field(s) not finite number')
})
it('should not error when all quantity fields are zero', function () {
m.chai.expect(() => {
flashState.setFlashingFlag()
flashState.setProgressState({
flashing: 0,
verifying: 0,
succeeded: 0,
failed: 0,
percentage: 0,
eta: 0,
speed: 0,
totalSpeed: 0
})
}).to.not.throw()
})
})
describe('.getFlashResults()', function () {