jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-15 07:16:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): fix multi-writes analytics (#2295)

Browse Source 
We make the analytics block into a function `handleErrorLogging` and
use it in the fail event that happens during multi-writes. Previously
error events would be handled when single drives were flashed on Promise
rejection, instead we now only handle the Promise rejection when all
devices fail as a special event.

Change-Type: patch
Changelog-Entry: Fix multi-writes analytics by reusing existing logic in
multi-write events.
This commit is contained in:
Benedict Aas 2018-05-02 22:02:31 +01:00 committed by GitHub
parent d7211b130b
commit 71064cc760
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 41 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
lib/gui/app/modules/image-writer.js
View File

@ -60,6 +60,35 @@ const getApplicationEntryPoint = () => {
return path.resolve(PROJECT_ROOT, relativeEntryPoint)
}
/**
* @summary Handle a flash error and log it to analytics
* @function
* @private
*
* @param {Error} error - error object
* @param {Object} analyticsData - analytics object
*
* @example
* handleErrorLogging({ code: 'EUNPLUGGED' }, { image: 'resin.img' })
*/
const handleErrorLogging = (error, analyticsData) => {
if (error.code === 'EVALIDATION') {
analytics.logEvent('Validation error', analyticsData)
} else if (error.code === 'EUNPLUGGED') {
analytics.logEvent('Drive unplugged', analyticsData)
} else if (error.code === 'EIO') {
analytics.logEvent('Input/output error', analyticsData)
} else if (error.code === 'ENOSPC') {
analytics.logEvent('Out of space', analyticsData)
} else if (error.code === 'ECHILDDIED') {
analytics.logEvent('Child died unexpectedly', analyticsData)
} else {
analytics.logEvent('Flash error', _.merge({
error: errors.toJSON(error)
}, analyticsData))
}
}
/**
* @summary Perform write operation
* @function
@ -127,9 +156,16 @@ exports.performWrite = (image, drives, onProgress) => {
})
const flashResults = {}
const analyticsData = {
image,
drives,
uuid: flashState.getFlashUuid(),
unmountOnSuccess: settings.get('unmountOnSuccess'),
validateWriteOnSuccess: settings.get('validateWriteOnSuccess')
}
ipc.server.on('fail', (error) => {
console.log('Fail:', error)
ipc.server.on('fail', ({ device, error }) => {
handleErrorLogging(error, analyticsData)
})
ipc.server.on('done', (event) => {
@ -275,20 +311,9 @@ exports.flash = (image, drives) => {
errorCode: error.code
})
if (error.code === 'EVALIDATION') {
analytics.logEvent('Validation error', analyticsData)
} else if (error.code === 'EUNPLUGGED') {
analytics.logEvent('Drive unplugged', analyticsData)
} else if (error.code === 'EIO') {
analytics.logEvent('Input/output error', analyticsData)
} else if (error.code === 'ENOSPC') {
analytics.logEvent('Out of space', analyticsData)
} else if (error.code === 'ECHILDDIED') {
analytics.logEvent('Child died unexpectedly', analyticsData)
} else {
analytics.logEvent('Flash error', _.merge({
error: errors.toJSON(error)
}, analyticsData))
// eslint-disable-next-line no-magic-numbers
if (drives.length > 1) {
analytics.logEvent('Write failed', analyticsData)
}
return Bluebird.reject(error)