jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-22 18:56:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(CLI): prevent flashing an image that is larger than the drive (#1223)

Browse Source 
The CLI still happily let you flash an image that doesn't fit on the
drive. This commit prevents such scenario right before flashing, but we
should still implement a smarter CLI drive detection widget for when the
user runs the CLI interactively.

Change-Type: patch
Changelog-Entry: Prevent flashing an image that is larger than the drive with the CLI.
Fixes: https://github.com/resin-io/etcher/issues/858
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2017-03-28 13:55:58 -04:00 committed by GitHub
parent 57952f6f55
commit 78a3206295
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/cli/writer.js
View File

@ -22,6 +22,8 @@ const fs = Bluebird.promisifyAll(require('fs'));
const os = require('os'); const os = require('os');
const unmount = require('./unmount'); const unmount = require('./unmount');
const imageStream = require('../image-stream'); const imageStream = require('../image-stream');
const errors = require('../shared/errors');
const constraints = require('../shared/constraints');
/** /**
* @summary Write an image to a disk drive * @summary Write an image to a disk drive
@ -67,6 +69,15 @@ exports.writeImage = (imagePath, drive, options, onProgress) => {
return fs.openAsync(drive.raw, 'rs+'); return fs.openAsync(drive.raw, 'rs+');
}).then((driveFileDescriptor) => { }).then((driveFileDescriptor) => {
return imageStream.getFromFilePath(imagePath).then((image) => { return imageStream.getFromFilePath(imagePath).then((image) => {
if (!image.size.final.estimation && !constraints.isDriveLargeEnough(drive, {
size: image.size.final.value
})) {
throw errors.createUserError(
'The image you selected is too big for this drive',
'Plug in a bigger drive and try again'
);
}
return imageWrite.write({ return imageWrite.write({
fd: driveFileDescriptor, fd: driveFileDescriptor,
device: drive.raw, device: drive.raw,