jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-24 11:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): no write after elevation in GNU/Linux (#721)

Browse Source 
When the application is packaged as an AppImage, we're accidentally not
applying the whitespace escaping routine, causing images that contain
white spaces to cause Etcher to stall and never start the write.

The issue was even harder to debug given that the problem was not
reproducible when running Etcher from `npm start`.

Change-Type: patch
Changelog-Entry: Fix flashing never starting after elevation in GNU/Linux.
Fixes: https://github.com/resin-io/etcher/issues/631
Fixes: https://github.com/resin-io/etcher/issues/665
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-09-25 23:06:15 -04:00 committed by GitHub
parent 95aaea5a0f
commit 81751743fe
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/src/child-writer/writer-proxy.js
View File

@ -131,6 +131,12 @@ return isElevated().then((elevated) => {
if (process.env.APPIMAGE && process.env.APPDIR) {
const mountPoint = process.env.APPDIR + '-elevated';
// Translate the current arguments to
// point to the new mount location.
const translatedArguments = _.map(process.argv, (argv) => {
return argv.replace(process.env.APPDIR, mountPoint);
});
// We wrap the command with `sh -c` since it seems
// the only way to effectively run many commands
// with a graphical sudo interface,
@ -155,13 +161,7 @@ return isElevated().then((elevated) => {
'&&'
]
.concat(commandPrefix)
// Translate the current arguments to
// point to the new mount location.
.concat(_.map(process.argv, (argv) => {
return argv.replace(process.env.APPDIR, mountPoint);
}))
.concat(utils.escapeWhiteSpacesFromArguments(translatedArguments))
.concat([
';',