jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-24 23:37:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explain why we toggle body's display manually instead of using ngCloak

Browse Source
This commit is contained in:
Juan Cruz Viotti 2016-01-19 10:14:37 -04:00
parent ffbccc5aec
commit 817a6f591b
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
build/browser/app.js
View File

@ -78,7 +78,14 @@ app.controller('AppController', function($q, DriveScannerService, SelectionState
this.restart(); this.restart();
// We're ready to unhide the application now // We manually add `style="display: none;"` to <body>
// and unset it here instead of using ngCloak since
// the latter takes effect as soon as the Angular
// library was loaded, but doesn't always mean that
// the application is ready, causing the application
// to be shown in an unitialized state for some milliseconds.
// Here in the controller, we are sure things are
// completely up and running.
document.querySelector('body').style.display = 'initial'; document.querySelector('body').style.display = 'initial';
this.selectImage = function() { this.selectImage = function() {

9
lib/browser/app.js
View File

@ -77,7 +77,14 @@ app.controller('AppController', function($q, DriveScannerService, SelectionState
this.restart(); this.restart();
// We're ready to unhide the application now // We manually add `style="display: none;"` to <body>
// and unset it here instead of using ngCloak since
// the latter takes effect as soon as the Angular
// library was loaded, but doesn't always mean that
// the application is ready, causing the application
// to be shown in an unitialized state for some milliseconds.
// Here in the controller, we are sure things are
// completely up and running.
document.querySelector('body').style.display = 'initial'; document.querySelector('body').style.display = 'initial';
this.selectImage = function() { this.selectImage = function() {