From 856f53067bd53bd5b3ca1c41f83733ec30097268 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Tue, 14 Nov 2017 08:51:01 -0400 Subject: [PATCH] chore: revert "chore: don't zip AppImages" (#1842) For usability purposes. We get a high volume of support requests from GNU/Linux newbies that get deeply confused about setting execution permissions. This reverts commit b2d3d0ecb8eadd14593c3b7587775d1ac4b5475e. --- Makefile | 9 +++++++-- README.md | 4 ---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 536a276c..8e83d431 100644 --- a/Makefile +++ b/Makefile @@ -346,6 +346,11 @@ $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET -w $(BUILD_TEMPORARY_DIRECTORY) \ -o $@ +$(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip: \ + $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage \ + | $(BUILD_DIRECTORY) + ./scripts/build/zip-file.sh -f $< -s $(PLATFORM) -o $@ + $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-Portable-$(APPLICATION_VERSION)-$(TARGET_ARCH).exe: \ | $(BUILD_DIRECTORY) TARGET_ARCH=$(TARGET_ARCH) $(NPX) build --win portable $(ELECTRON_BUILDER_OPTIONS) \ @@ -408,7 +413,7 @@ PUBLISH_AWS_S3 += \ endif ifeq ($(PLATFORM),linux) -electron-installer-appimage: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage +electron-installer-appimage: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip electron-installer-debian: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)_$(APPLICATION_VERSION_DEBIAN)_$(TARGET_ARCH_DEBIAN).deb electron-installer-redhat: $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)-$(APPLICATION_VERSION_REDHAT).$(TARGET_ARCH_REDHAT).rpm cli-installer-tar-gz: $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH).tar.gz @@ -418,7 +423,7 @@ TARGETS += \ electron-installer-redhat \ cli-installer-tar-gz PUBLISH_AWS_S3 += \ - $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage \ + $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip \ $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH).tar.gz PUBLISH_BINTRAY_DEBIAN += \ $(BUILD_DIRECTORY)/$(APPLICATION_NAME_ELECTRON)_$(APPLICATION_VERSION_DEBIAN)_$(TARGET_ARCH_DEBIAN).deb diff --git a/README.md b/README.md index a20ba795..65c729e0 100644 --- a/README.md +++ b/README.md @@ -39,10 +39,6 @@ Installers Refer to the [downloads page][etcher] for the latest pre-made installers for all supported operating systems. -#### AppImage - -Set executable permissions on the `.AppImage` file and double-click it. - #### Debian and Ubuntu based Package Repository (GNU/Linux x86/x64) 1. Add Etcher debian repository: