jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-24 03:36:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove forwarding of SafeWebview console messages

Browse Source 
Change-type: patch
Signed-off-by: Lorenzo Alberto Maria Ambrosi <lorenzoa@balena.io>
This commit is contained in:
Lorenzo Alberto Maria Ambrosi 2018-12-18 15:14:21 +01:00
parent 9077c95cdd
commit 87533f4417
1 changed files with 1 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/gui/app/components/safe-webview/safe-webview.jsx
View File

@ -101,8 +101,7 @@ class SafeWebview extends react.PureComponent {
this.eventTuples = [
[ 'did-fail-load', this.didFailLoad ],
[ 'did-get-response-details', this.didGetResponseDetails ],
[ 'new-window', this.constructor.newWindow ],
[ 'console-message', this.constructor.consoleMessage ]
[ 'new-window', this.constructor.newWindow ]
]
// Make a persistent electron session for the webview
@ -226,38 +225,6 @@ class SafeWebview extends react.PureComponent {
electron.shell.openExternal(url.href)
}
}
/**
* @summary Forward specially-formatted console messages from the webview
* @param {Event} event - event object
*
* @example
*
* // In the webview
* console.log('Good night!')
*/
static consoleMessage (event) {
if (_.isNil(event.message)) {
return
}
let message = event.message
try {
message = JSON.parse(event.message)
} catch (error) {
// Ignore
}
if (message.command === 'error') {
analytics.logException(message.data)
} else {
analytics.logEvent('SafeWebview console message', {
message,
applicationSessionUuid: store.getState().toJS().applicationSessionUuid,
flashingWorkflowUuid: store.getState().toJS().flashingWorkflowUuid
})
}
}
}
SafeWebview.propTypes = {