From 8b13a2311762f64a30d0cb85af085488aa8b433e Mon Sep 17 00:00:00 2001 From: Jonas Hermsmeier Date: Thu, 9 Nov 2017 14:44:42 +0100 Subject: [PATCH] fix(sdk): Remove event listeners on unsubscribe (#1834) Change-Type: patch --- lib/shared/sdk/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/shared/sdk/index.js b/lib/shared/sdk/index.js index dcbc514e..1e7f5a8e 100644 --- a/lib/shared/sdk/index.js +++ b/lib/shared/sdk/index.js @@ -180,7 +180,6 @@ SDK.Scanner = class Scanner extends EventEmitter { } this.adapters.forEach((adapter) => { - // Adapter.stopScan() adapter.removeListener('devices', this.onDevices) adapter.removeListener('error', this.onError) }) @@ -231,6 +230,9 @@ SDK.Scanner = class Scanner extends EventEmitter { return this } + instance.removeListener('devices', this.onDevices) + instance.removeListener('error', this.onError) + this.adapters.delete(instance.name) this.emit('unsubscribe', adapter)