From 4ef7dae3c41863a9eced2a12dc86d50667386fa1 Mon Sep 17 00:00:00 2001
From: Juan Cruz Viotti <jviottidc@gmail.com>
Date: Fri, 1 Apr 2016 09:04:55 -0400
Subject: [PATCH] Use SettingsService in FinishController

EXposing the settings from the `FinishController` is a better approach
that instantiating the `SettingsController` in the Finish page template.
---
 lib/browser/pages/finish/controllers/finish.js      | 9 ++++++++-
 lib/browser/pages/finish/templates/success.tpl.html | 4 +---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/lib/browser/pages/finish/controllers/finish.js b/lib/browser/pages/finish/controllers/finish.js
index 21d145ce..90e5cdad 100644
--- a/lib/browser/pages/finish/controllers/finish.js
+++ b/lib/browser/pages/finish/controllers/finish.js
@@ -16,7 +16,14 @@
 
 'use strict';
 
-module.exports = function($state, SelectionStateService, ImageWriterService, AnalyticsService) {
+module.exports = function($state, SelectionStateService, ImageWriterService, AnalyticsService, SettingsService) {
+
+  /**
+   * @summary Settings data
+   * @type Object
+   * @public
+   */
+  this.settings = SettingsService.data;
 
   /**
    * @summary Restart the burning process
diff --git a/lib/browser/pages/finish/templates/success.tpl.html b/lib/browser/pages/finish/templates/success.tpl.html
index 397e99fb..d1b6eb86 100644
--- a/lib/browser/pages/finish/templates/success.tpl.html
+++ b/lib/browser/pages/finish/templates/success.tpl.html
@@ -2,9 +2,7 @@
   <div class="col-xs">
     <div class="box text-center">
       <h3><span class="tick tick--success" class="space-right-tiny"></span> Burn Complete!</h3>
-      <p class="soft"
-        ng-controller="SettingsController as settings"
-        ng-show="settings.storage.unmountOnSuccess">Safely ejected and ready for use</p>
+      <p class="soft" ng-show="finish.settings.unmountOnSuccess">Safely ejected and ready for use</p>
 
       <div class="row center-xs space-vertical-large">
         <div class="col-xs-4 space-medium">