From 99538e3120650c852abd928610f98632fdaf48fa Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Tue, 13 Dec 2016 14:03:09 -0400 Subject: [PATCH] doc: recommend `make electron-develop` to clean dependency tree (#974) Because of NPM shrinkwrap, we recommend having a clean dependency tree in `CONTRIBUTING.md` before upgrading a dependency. We currently recommend maually wiping out `node_modules`, but since the `electron-develop` make target already does that, is more user friendly to recommend that instead. Signed-off-by: Juan Cruz Viotti --- docs/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 1c47e01f..5dcdb9ca 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -37,7 +37,7 @@ dependency. Use the following steps to ensure everything goes flawlessly: -- Delete your `node_modules/` to ensure you don't have extraneous dependencies +- Run `make electron-develop` to ensure you don't have extraneous dependencies you might have brought during development, or you are running older dependencies because you come from another branch or reference.